Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit status code error when detect Security Issues #106

Merged

Conversation

@Jibbarth
Copy link
Collaborator

commented May 20, 2019

Q A
Bug fix? no
New feature? yes
Fixed tickets N/A

I think when security issues are detected, we should in every case return an exit error code

@nunomaduro nunomaduro merged commit ad79fa7 into nunomaduro:master May 20, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 20, 2019

Thanks!

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 20, 2019

@Jibbarth Can you make this optional as like other min options? And also update the docs?

@Jibbarth

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

In effect, the travis build fail with composer prefer-lowest flag 😓

What do you want in option ? --disable-security-check ? I think it should be enabled by default, WDYT ?

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 20, 2019

Sounds good: Make it explicit.

@Jibbarth Jibbarth deleted the Jibbarth:feature/error-if-security-issue branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.