Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display insight class name (#137) #139

Merged

Conversation

@Jibbarth
Copy link
Collaborator

commented May 28, 2019

Q A
Bug fix? no
New feature? yes
Fixed tickets #137

Display Insight FQCN for each section to help users to know wich Sniff/Insight is applied

@nunomaduro
Copy link
Owner

left a comment

Thanks!

Show resolved Hide resolved src/Domain/Contracts/Insight.php Outdated
Show resolved Hide resolved src/Domain/Insights/Sniff.php Outdated
Show resolved Hide resolved src/Domain/Insights/Sniff.php Outdated

Jibbarth and others added some commits May 28, 2019

Update src/Domain/Contracts/Insight.php
Co-Authored-By: Nuno Maduro <enunomaduro@gmail.com>
@nunomaduro
Copy link
Owner

left a comment

Thanks!

@nunomaduro nunomaduro merged commit 367582a into nunomaduro:master May 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Jibbarth Jibbarth deleted the Jibbarth:feature/137-display-insight-class-name branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.