Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect cyclomatic complexity calculation (#134) #150

Merged
merged 1 commit into from May 31, 2019

Conversation

@spyric
Copy link
Contributor

commented May 30, 2019

Q A
Bug fix? yes
New feature? no
Fixed tickets #134

This PR fixes incorrect calculation of cyclomatic complexity when using type hint in arguments and return value in functions declaration

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

Maybe @Jibbarth @olivernybroe can help on this?

@nunomaduro nunomaduro added the bug label May 30, 2019

@olivernybroe

This comment has been minimized.

Copy link
Collaborator

commented May 31, 2019

Hmm this makes sense yeah. Would you mind adding in a comment in the code to explain the early exist. Just so we in the future know why it's there.

@nunomaduro nunomaduro merged commit 0bba518 into nunomaduro:master May 31, 2019

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 31, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.