Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComposerMustBeValid and ComposerLockMustBeFresh insights #169

Merged
merged 4 commits into from Jun 8, 2019

Conversation

@Jibbarth
Copy link
Collaborator

@Jibbarth Jibbarth commented Jun 8, 2019

Q A
Bug fix? no
New feature? yes
Fixed tickets #...

Add new Insights about composer.

Example:

• [Architecture] Composer.json is not valid:
  composer.json: The property name is required
  composer.json: The property description is required
  composer.json: No license specified, it is recommended to do so. For closed-source software you may use "proprietary" as license.

• [Architecture] The lock file is not up to date with the latest changes in composer.json:
  You may be getting outdated dependencies. Run update to update them.
@Jibbarth Jibbarth force-pushed the feature/new-composer-insights branch from 5f91c23 to 5678e16 Jun 8, 2019
Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Really nice changes! Would it be too much work to add blacklist of different composer package names?
This way we can show that they have to change the package name away from laravel/laravel in the Laravel preset :) (else this could be another pr)

Loading

@Jibbarth
Copy link
Collaborator Author

@Jibbarth Jibbarth commented Jun 8, 2019

Loading

@olivernybroe
Copy link
Collaborator

@olivernybroe olivernybroe commented Jun 8, 2019

Oh yeah, totally forgot, sorry! :)

Loading

Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Looks great, sound like a nice addition. Could you add a few tests for this also?

Loading

@Jibbarth
Copy link
Collaborator Author

@Jibbarth Jibbarth commented Jun 8, 2019

Could you add a few tests for this also?

I'll try 😉

Loading

@Jibbarth Jibbarth force-pushed the feature/new-composer-insights branch from 66e9f43 to e04b204 Jun 8, 2019
@Jibbarth
Copy link
Collaborator Author

@Jibbarth Jibbarth commented Jun 8, 2019

@olivernybroe Tests added. Is it good for you ?

Loading

@Jibbarth Jibbarth requested a review from olivernybroe Jun 8, 2019
Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Looks great! The tests are nice.
I'll say, just go ahead and merge it in :)

Loading

@Jibbarth Jibbarth merged commit 5d0e1af into nunomaduro:master Jun 8, 2019
1 check passed
Loading
@Jibbarth
Copy link
Collaborator Author

@Jibbarth Jibbarth commented Jun 8, 2019

Thanks a lot for the review @olivernybroe 👍

Loading

@Jibbarth Jibbarth deleted the feature/new-composer-insights branch Jun 8, 2019
@Jibbarth Jibbarth mentioned this pull request Jun 20, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants