Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #172 when remove ForbiddenSecurityIssues Insight #175

Merged

Conversation

@Jibbarth
Copy link
Collaborator

@Jibbarth Jibbarth commented Jun 12, 2019

Q A
Bug fix? yes
New feature? no
Fixed tickets #172

When ForbiddenSecurityIssues is removed in config, we caught an exception.

This should fix it

Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Looks great, and the code is a simple change. You can just merge it in :)

Do we have any big changes since last release, else we should maybe make a minor release also?

Loading

@Jibbarth
Copy link
Collaborator Author

@Jibbarth Jibbarth commented Jun 14, 2019

@olivernybroe looking at changelog we have 2 new Insights, a composer.json update, more documentation, and this fix.

With new Insights, I think we should tag 1.7 if we follow semver. But maybe we should wait the new wordpress preset before tagging ?
WDYT ?

Anyway, thanks for the review 👍

Loading

@Jibbarth Jibbarth merged commit ff83634 into nunomaduro:master Jun 14, 2019
1 check passed
Loading
@olivernybroe
Copy link
Collaborator

@olivernybroe olivernybroe commented Jun 14, 2019

Oh yeah, I guess 2 new insights is a lot for a small release 👍

Let's wait for next change bigger change. Which hopefully is wordpress preset

Loading

src/Domain/Results.php Show resolved Hide resolved
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants