Fix issue #172 when remove ForbiddenSecurityIssues Insight #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivernybroe
approved these changes
Jun 12, 2019
|
@olivernybroe looking at changelog we have 2 new Insights, a composer.json update, more documentation, and this fix. With new Insights, I think we should tag 1.7 if we follow semver. But maybe we should wait the new wordpress preset before tagging ? Anyway, thanks for the review 👍 |
|
Oh yeah, I guess 2 new insights is a lot for a small release 👍 Let's wait for next change bigger change. Which hopefully is wordpress preset |
nunomaduro
reviewed
Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ForbiddenSecurityIssues is removed in config, we caught an exception.
This should fix it