Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize analyse of one file or specific directory #195

Merged

Conversation

@Jibbarth
Copy link
Collaborator

commented Jun 23, 2019

Q A
Bug fix? no
New feature? yes
Fixed tickets #148

This authorize the analyse of one file or a subdirectory.

To do this, I assume some Insight are "Globals" (ie all related to composer)

So when we launch an analyse on a subdirectory, I remove theses Insights in config.

For launch on a specific file, I modified the LocalFileRepository to append file directly in Finder.

@Jibbarth Jibbarth force-pushed the Jibbarth:feature/148-analyse-invidual-file branch from 4430eda to e083487 Jun 23, 2019

@nunomaduro nunomaduro requested a review from olivernybroe Jun 23, 2019

@olivernybroe
Copy link
Collaborator

left a comment

Looks great and fairly simple solution! 🎉

I've added a few comments.
Btw could you add the change to docs, so users knows this is possible? :)

src/Domain/Kernel.php Show resolved Hide resolved
src/Domain/Kernel.php Show resolved Hide resolved

@Jibbarth Jibbarth force-pushed the Jibbarth:feature/148-analyse-invidual-file branch from 6fa8271 to 395d128 Jun 23, 2019

@olivernybroe
Copy link
Collaborator

left a comment

Looks great! :)

We could consider adding in a section in the docs for setting it up with PHPStorm (I have not done this myself yet). A quick example is ECS which shows how it is done in their docs. https://github.com/Symplify/EasyCodingStandard/blob/master/README.md#phpstorm

@nunomaduro
Copy link
Owner

left a comment

Looks good to be merged to me.

@Jibbarth Jibbarth merged commit a967bda into nunomaduro:master Jun 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jibbarth

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 23, 2019

Thanks both of you for the review.

@olivernybroe, I'll test in the week an integration with PHPStorm 😉

@Jibbarth Jibbarth deleted the Jibbarth:feature/148-analyse-invidual-file branch Jun 23, 2019

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented Jun 23, 2019

Thanks for this!

@Jibbarth Jibbarth referenced this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.