Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize analyse of one file or specific directory #195

Merged

Conversation

Jibbarth
Copy link
Collaborator

Q A
Bug fix? no
New feature? yes
Fixed tickets #148

This authorize the analyse of one file or a subdirectory.

To do this, I assume some Insight are "Globals" (ie all related to composer)

So when we launch an analyse on a subdirectory, I remove theses Insights in config.

For launch on a specific file, I modified the LocalFileRepository to append file directly in Finder.

@Jibbarth Jibbarth force-pushed the feature/148-analyse-invidual-file branch from 4430eda to e083487 Compare June 23, 2019 10:52
@Jibbarth Jibbarth added the enhancement New feature or request label Jun 23, 2019
Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and fairly simple solution! 🎉

I've added a few comments.
Btw could you add the change to docs, so users knows this is possible? :)

src/Domain/Kernel.php Show resolved Hide resolved
src/Domain/Kernel.php Show resolved Hide resolved
@Jibbarth Jibbarth force-pushed the feature/148-analyse-invidual-file branch from 6fa8271 to 395d128 Compare June 23, 2019 14:47
Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :)

We could consider adding in a section in the docs for setting it up with PHPStorm (I have not done this myself yet). A quick example is ECS which shows how it is done in their docs. https://github.com/Symplify/EasyCodingStandard/blob/master/README.md#phpstorm

Copy link
Owner

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be merged to me.

@Jibbarth Jibbarth merged commit a967bda into nunomaduro:master Jun 23, 2019
@Jibbarth
Copy link
Collaborator Author

Thanks both of you for the review.

@olivernybroe, I'll test in the week an integration with PHPStorm 😉

@Jibbarth Jibbarth deleted the feature/148-analyse-invidual-file branch June 23, 2019 16:32
@nunomaduro
Copy link
Owner

Thanks for this!

@Jibbarth Jibbarth mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants