Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[Refact] configuration class #283
In order to fix this comment, I add a Configuration Class that carry config provided by user.
The Configuration class is resolved when container boot, so we can use DependencyInjection or container to retrieve configuration.
As phpcsfixer came with it, I use symfony/options-resolver to improve configuration validation.
I think this refact is needed, because the config file is growing, and we should have a simpler way to validate it, and also retrieve it.
olivernybroe left a comment
Wauw, this is really clean, I love it
I think this will allow us to do a lot of extra stuff soo much easier in the future.
I only had a few comments about some naming, but else it just looks spot on