Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/progress bar #291

Merged
merged 3 commits into from Oct 20, 2019

Conversation

@Jibbarth
Copy link
Collaborator

Jibbarth commented Oct 19, 2019

Q A
Bug fix? yes
New feature? no
Fixed tickets #...

I noticed the progress bar is different from v1.9.0 to master version.

After investigating, it appeared when we dropped ECS dependency. In fact, ECS use the SymfonyStyle class to create a ProgressBar, that change default display of progress bar: https://github.com/symfony/console/blob/master/Style/SymfonyStyle.php#L331-L339

So I restored this output style for progress bar.

In the second commit, I tried to explore how we can display correctly message without break the progress bar output.

Here the render:
phpinsights-progress-bar

WDYT ?

@Jibbarth Jibbarth requested a review from olivernybroe Oct 19, 2019
}
private function processFile(SplFileInfo $file): void
{
if (! ($file instanceof SymfonySplFileInfo)) {

This comment has been minimized.

Copy link
@Jibbarth

Jibbarth Oct 19, 2019

Author Collaborator

I removed this, FilesRepository return a Traversable of SymfonySplFileInfo

@nunomaduro

This comment has been minimized.

Copy link
Owner

nunomaduro commented Oct 19, 2019

Sounds awesome thanks!

Copy link
Collaborator

olivernybroe left a comment

Cool! Thanks dude!

@Jibbarth Jibbarth merged commit 94dd319 into nunomaduro:master Oct 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jibbarth Jibbarth deleted the Jibbarth:improve/progress-bar branch Oct 20, 2019
@Jibbarth

This comment has been minimized.

Copy link
Collaborator Author

Jibbarth commented Oct 20, 2019

Thanks for the review guys 👍

@Jibbarth Jibbarth mentioned this pull request Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.