Improve/progress bar #291
Merged
Improve/progress bar #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibbarth
commented
Oct 19, 2019
| } | ||
|
|
||
| private function processFile(SplFileInfo $file): void | ||
| { | ||
| if (! ($file instanceof SymfonySplFileInfo)) { |
There was a problem hiding this comment.
I removed this, FilesRepository return a Traversable of SymfonySplFileInfo
nunomaduro
approved these changes
Oct 19, 2019
|
Sounds awesome thanks! |
olivernybroe
approved these changes
Oct 19, 2019
|
Thanks for the review guys 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the progress bar is different from v1.9.0 to master version.
After investigating, it appeared when we dropped ECS dependency. In fact, ECS use the SymfonyStyle class to create a ProgressBar, that change default display of progress bar: https://github.com/symfony/console/blob/master/Style/SymfonyStyle.php#L331-L339
So I restored this output style for progress bar.
In the second commit, I tried to explore how we can display correctly message without break the progress bar output.
Here the render:
WDYT ?