Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/progress bar #291

merged 3 commits into from Oct 20, 2019

Improve/progress bar #291

merged 3 commits into from Oct 20, 2019


Copy link

@Jibbarth Jibbarth commented Oct 19, 2019

Bug fix? yes
New feature? no
Fixed tickets #...

I noticed the progress bar is different from v1.9.0 to master version.

After investigating, it appeared when we dropped ECS dependency. In fact, ECS use the SymfonyStyle class to create a ProgressBar, that change default display of progress bar:

So I restored this output style for progress bar.

In the second commit, I tried to explore how we can display correctly message without break the progress bar output.

Here the render:


@Jibbarth Jibbarth added the enhancement label Oct 19, 2019
@Jibbarth Jibbarth requested a review from olivernybroe Oct 19, 2019

private function processFile(SplFileInfo $file): void
if (! ($file instanceof SymfonySplFileInfo)) {
Copy link
Collaborator Author

@Jibbarth Jibbarth Oct 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this, FilesRepository return a Traversable of SymfonySplFileInfo

Copy link

@nunomaduro nunomaduro commented Oct 19, 2019

Sounds awesome thanks!

Copy link
Sponsor Collaborator

@olivernybroe olivernybroe left a comment

Cool! Thanks dude!

@Jibbarth Jibbarth merged commit 94dd319 into nunomaduro:master Oct 20, 2019
1 check passed
@Jibbarth Jibbarth deleted the improve/progress-bar branch Oct 20, 2019
Copy link
Collaborator Author

@Jibbarth Jibbarth commented Oct 20, 2019

Thanks for the review guys 👍

@Jibbarth Jibbarth mentioned this pull request Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants