Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes duplicated no empty comment sniff #311

Merged
merged 1 commit into from Nov 16, 2019

Conversation

@nunomaduro
Copy link
Owner

nunomaduro commented Nov 16, 2019

Q A
Bug fix? yes
New feature? no

This pull request fixes the fact that the EmptyComment sniff is duplicated with NoEmptyComment from php cs fixer.

@nunomaduro nunomaduro requested review from Jibbarth and olivernybroe Nov 16, 2019
Copy link
Collaborator

Jibbarth left a comment

Seems good to me 👍

@nunomaduro nunomaduro merged commit 143a56e into master Nov 16, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@nunomaduro nunomaduro deleted the fix/removes-empty-comment-sniff branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.