Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad place of some insights #313

Merged
merged 5 commits into from Nov 16, 2019
Merged

fix: bad place of some insights #313

merged 5 commits into from Nov 16, 2019

Conversation

nunomaduro
Copy link
Owner

@nunomaduro nunomaduro commented Nov 16, 2019

Q A
Bug fix? yes

Some insights here place in code/arquicture but they are really about style.

@nunomaduro nunomaduro requested a review from Jibbarth Nov 16, 2019
docs/insights/style.md Outdated Show resolved Hide resolved
docs/insights/style.md Outdated Show resolved Hide resolved
docs/insights/style.md Outdated Show resolved Hide resolved
docs/insights/style.md Outdated Show resolved Hide resolved
src/Domain/Metrics/Code/Classes.php Show resolved Hide resolved
docs/insights/code.md Outdated Show resolved Hide resolved
@nunomaduro nunomaduro requested a review from Jibbarth Nov 16, 2019
Copy link
Collaborator

@Jibbarth Jibbarth left a comment

👍

@Jibbarth Jibbarth merged commit 72953f7 into master Nov 16, 2019
2 checks passed
@Jibbarth Jibbarth deleted the fix/php-comment-separator branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants