Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] forbidden trait exclude #316

Merged
merged 3 commits into from
Nov 17, 2019
Merged

[Fix] forbidden trait exclude #316

merged 3 commits into from
Nov 17, 2019

Conversation

Jibbarth
Copy link
Collaborator

Q A
Bug fix? yes
New feature? no
Fixed tickets #315

@Jibbarth Jibbarth added the bug Something isn't working label Nov 17, 2019
@Jibbarth Jibbarth requested review from nunomaduro and olivernybroe and removed request for nunomaduro November 17, 2019 11:09
olivernybroe
olivernybroe approved these changes Nov 17, 2019
View reviewed changes
Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing the bug :)

@Jibbarth Jibbarth merged commit 80fffdc into nunomaduro:master Nov 17, 2019
@Jibbarth Jibbarth deleted the fix/315-forbidden-trait-exclude branch November 17, 2019 12:34
@Jibbarth Jibbarth mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivernybroe olivernybroe olivernybroe approved these changes

@nunomaduro nunomaduro Awaiting requested review from nunomaduro

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jibbarth @olivernybroe