Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] assert ide is defined before resolving it #319

Conversation

@Jibbarth
Copy link
Collaborator

Jibbarth commented Nov 17, 2019

Q A
Bug fix? yes
New feature? no
Fixed tickets #318

In default stub, we add 'ide' => null to configure url handle. However, this null value wasn't catched.

This is now fixed

@Jibbarth Jibbarth added the bug label Nov 17, 2019
@Jibbarth Jibbarth requested review from nunomaduro and olivernybroe Nov 17, 2019
@Jibbarth Jibbarth merged commit 91f8a81 into nunomaduro:master Nov 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jibbarth Jibbarth deleted the Jibbarth:fix/assert-ide-is-defined-before-resolving-it branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.