Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Forbidden final classes exclude #326

Merged
merged 5 commits into from Dec 1, 2019
Merged

[Fix] Forbidden final classes exclude #326

merged 5 commits into from Dec 1, 2019

Conversation

jochensengier
Copy link
Contributor

@jochensengier jochensengier commented Nov 27, 2019

Q A
Bug fix? yes
New feature? no
Fixed tickets #325

@olivernybroe olivernybroe requested a review from Jibbarth Nov 27, 2019
Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Great 👍 Are you able to add tests ? If you cannot, don't worry, I'll add them later 😉

@jochensengier
Copy link
Contributor Author

@jochensengier jochensengier commented Nov 28, 2019

@Jibbarth Please keep in mind I don't have a lot of experience writing tests, but I gave it a try.
Could you triple check please?

Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Thanks for adding tests ! We're almost there 😉

src/Domain/Metrics/Architecture/Classes.php Outdated Show resolved Hide resolved
@jochensengier
Copy link
Contributor Author

@jochensengier jochensengier commented Nov 29, 2019

Thanks for the suggestions, learned a lot!

@nunomaduro nunomaduro requested a review from Jibbarth Nov 29, 2019
Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Thank you so much for this PR 😍

I added one more little commit to properly handle excluded files, that I noticed something don't work with the assert(1, $errors) in the tests you added

@Jibbarth Jibbarth merged commit e360528 into nunomaduro:master Dec 1, 2019
1 check passed
@Jibbarth Jibbarth added the bug label Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants