New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Forbidden final classes exclude #326
[Fix] Forbidden final classes exclude #326
Conversation
jochensengier
commented
Nov 27, 2019
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
Fixed tickets | #325 |
Great
@Jibbarth Please keep in mind I don't have a lot of experience writing tests, but I gave it a try. |
Thanks for the suggestions, learned a lot! |
Thank you so much for this PR
I added one more little commit to properly handle excluded files, that I noticed something don't work with the assert(1, $errors)
in the tests you added