Skip to content

/phpinsights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Forbidden final classes exclude #326

Merged
merged 5 commits into from Dec 1, 2019

Conversation

@celcius-jochen
Copy link
Contributor

celcius-jochen commented Nov 27, 2019

Q A
Bug fix? yes
New feature? no
Fixed tickets #325
@celcius-jochen
[Fix] Forbidden final classes exclude
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7fb5c30
@olivernybroe olivernybroe requested a review from Jibbarth Nov 27, 2019
@Jibbarth
Jibbarth reviewed Nov 27, 2019
View changes
Copy link
Collaborator

Jibbarth left a comment

Great 👍 Are you able to add tests ? If you cannot, don't worry, I'll add them later 😉
@celcius-jochen
Add tests
Loading status checks…
ec02a43
@celcius-jochen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

celcius-jochen commented Nov 28, 2019

@Jibbarth Please keep in mind I don't have a lot of experience writing tests, but I gave it a try.
Could you triple check please?
@Jibbarth
Jibbarth requested changes Nov 28, 2019
View changes
Copy link
Collaborator

Jibbarth left a comment

Thanks for adding tests ! We're almost there 😉
src/Domain/Metrics/Architecture/Classes.php Outdated Show resolved Hide resolved
tests/Domain/Insights/ForbiddenFinalClassTest.php Show resolved Hide resolved
@celcius-jochen
Changes requested by Jibbarth
Loading status checks…
2b8254a
@celcius-jochen
Merge branch 'master' into celcius-jochen-patch-1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
350fd44
@celcius-jochen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

celcius-jochen commented Nov 29, 2019

Thanks for the suggestions, learned a lot!
@nunomaduro nunomaduro requested a review from Jibbarth Nov 29, 2019
@Jibbarth
Improve skipFile for forbiddenFinalClasses
Loading status checks…
8f3c4e6
@Jibbarth
Jibbarth approved these changes Dec 1, 2019
View changes
Copy link
Collaborator

Jibbarth left a comment

Thank you so much for this PR 😍

I added one more little commit to properly handle excluded files, that I noticed something don't work with the assert(1, $errors) in the tests you added
@Jibbarth Jibbarth merged commit e360528 into nunomaduro:master Dec 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jibbarth Jibbarth added the bug label Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jibbarth Jibbarth

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@celcius-jochen @Jibbarth
You can’t perform that action at this time.