[Fix] Forbidden final classes exclude #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jochensengier
commented
Nov 27, 2019
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Fixed tickets | #325 |
Jibbarth
reviewed
Nov 27, 2019
Great
|
@Jibbarth Please keep in mind I don't have a lot of experience writing tests, but I gave it a try. |
|
Thanks for the suggestions, learned a lot! |
Jibbarth
approved these changes
Dec 1, 2019
Thank you so much for this PR
I added one more little commit to properly handle excluded files, that I noticed something don't work with the assert(1, $errors) in the tests you added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.