Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Laravel 7 #369

Merged
merged 4 commits into from Mar 4, 2020
Merged

Conversation

@bastien-phi
Copy link
Contributor

bastien-phi commented Mar 4, 2020

Q A
Bug fix? no
New feature? no
Fixed tickets #368

This PR add support for Laravel 7.

phploc/phploc was updated to ^5.0|^6.0 as only version 6.0 supports symfony/console 5

I had to downgrade minimum stablility to RC because composer/composer has no stable version supporting symfony/console 5 but there is a 1.10.0-RC version. See on packagist

composer.json Show resolved Hide resolved
@bastien-phi

This comment has been minimized.

Copy link
Contributor Author

bastien-phi commented Mar 4, 2020

@nunomaduro Indeed, it looks like there is some kind of issue just putting illuminate/console: ^7.0

I got :

  Problem 1
    - Conclusion: don't install symfony/console v5.0.5
    - Conclusion: don't install symfony/console v5.0.4
    - Conclusion: don't install symfony/console v5.0.3
    - Conclusion: don't install symfony/console v5.0.2
    - Conclusion: don't install symfony/console v5.0.1
    - Installation request for phpunit/phpunit ^8.0 -> satisfiable by phpunit/phpunit[8.0.0, 8.0.1, 8.0.2, 8.0.3, 8.0.4, 8.0.5, 8.0.6, 8.1.0, 8.1.1, 8.1.2, 8.1.3, 8.1.4, 8.1.5, 8.1.6, 8.2.0, 8.2.1, 8.2.2, 8.2.3, 8.2.4, 8.2.5, 8.3.0, 8.3.1, 8.3.2, 8.3.3, 8.3.4, 8.3.5, 8.4.0, 8.4.1, 8.4.2, 8.4.3, 8.5.0, 8.5.1, 8.5.2].
    - Conclusion: don't install symfony/console v5.0.0
    - Installation request for phploc/phploc ^5.0|^6.0 -> satisfiable by phploc/phploc[5.0.0, 6.0.0, 6.0.1, 6.0.2].
    - illuminate/console v7.0.2 requires symfony/console ^5.0 -> satisfiable by symfony/console[v5.0.0, v5.0.0-RC1, v5.0.1, v5.0.2, v5.0.3, v5.0.4, v5.0.5].
    - illuminate/console v7.0.1 requires symfony/console ^5.0 -> satisfiable by symfony/console[v5.0.0, v5.0.0-RC1, v5.0.1, v5.0.2, v5.0.3, v5.0.4, v5.0.5].
    - illuminate/console v7.0.0 requires symfony/console ^5.0 -> satisfiable by symfony/console[v5.0.0, v5.0.0-RC1, v5.0.1, v5.0.2, v5.0.3, v5.0.4, v5.0.5].
    - Conclusion: don't install symfony/console v5.0.0-RC1
    - Installation request for illuminate/console ^7.0 -> satisfiable by illuminate/console[v7.0.0, v7.0.1, v7.0.2].

I can't understand the which package is causing the issue... Can you read this ?

@nunomaduro

This comment has been minimized.

@olivernybroe

This comment has been minimized.

Copy link
Collaborator

olivernybroe commented Mar 4, 2020

Yeah, so phploc v6 requires php7.3, which is required with laravel 7.

So if we are going to test only with Laravel 7, we will have to drop php7.2 support right?

@bastien-phi

This comment has been minimized.

Copy link
Contributor Author

bastien-phi commented Mar 4, 2020

thanks @nunomaduro . I finally found there was some incompatibility between phploc/phploc:6.x and phpunit/phpunit:8.x

@bastien-phi

This comment has been minimized.

Copy link
Contributor Author

bastien-phi commented Mar 4, 2020

@olivernybroe we can restore laravel ^5.8 and ^6.0 in dev-dependancies to keep php7.2 support with these but I don't see a way to have php7.2 and Laravel 7

@bastien-phi

This comment has been minimized.

Copy link
Contributor Author

bastien-phi commented Mar 4, 2020

IMHO it's not bad to drop support of php 7.2 ...

@olivernybroe

This comment has been minimized.

Copy link
Collaborator

olivernybroe commented Mar 4, 2020

@bastien-phi For maintaining it would be much nicer to just go straight for php7.4 😉

However, I think by dropping 7.2 support, we will exclude a lot of users, which is something we should be pretty careful with.

I think I'll let @nunomaduro make this decision 👍

@nunomaduro

This comment has been minimized.

Copy link
Owner

nunomaduro commented Mar 4, 2020

Let's #MoveForward, with the note on the readme.

@bastien-phi

This comment has been minimized.

Copy link
Contributor Author

bastien-phi commented Mar 4, 2020

Which means ? Test only on laravel 7 and drop php 7.2 support or this PR is ok right now ?

@bastien-phi bastien-phi requested a review from nunomaduro Mar 4, 2020
@nunomaduro nunomaduro merged commit 2eb547b into nunomaduro:master Mar 4, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nunomaduro

This comment has been minimized.

Copy link
Owner

nunomaduro commented Mar 4, 2020

Means all of this is good.

@bastien-phi bastien-phi deleted the bastien-phi:support_laravel_7 branch Mar 4, 2020
@bastien-phi

This comment has been minimized.

Copy link
Contributor Author

bastien-phi commented Mar 4, 2020

Thanks @nunomaduro !

@@ -47,7 +47,7 @@
"Tests\\": "tests/"
}
},
"minimum-stability": "stable",
"minimum-stability": "RC",

This comment has been minimized.

Copy link
@Jibbarth

Jibbarth Mar 4, 2020

Collaborator

This is here to use composer:1.10.0-rc, right ? which allow symfony/console:5.0 ?

This comment has been minimized.

Copy link
@bastien-phi

bastien-phi Mar 4, 2020

Author Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.