Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diffs-displays): aggregates diffs in the same error #377

Merged
merged 1 commit into from Mar 10, 2020

Conversation

@nunomaduro
Copy link
Owner

nunomaduro commented Mar 10, 2020

This pull request aggregates diffs of the same file in the same error:

Screenshot 2020-03-10 at 21 19 43

Previous, we were advising users to remove code ( that was added on the omitted issues ).

@nunomaduro nunomaduro requested review from Jibbarth and olivernybroe Mar 10, 2020
@nunomaduro

This comment has been minimized.

Copy link
Owner Author

nunomaduro commented Mar 10, 2020

Going to merge this now, so I can perform the release. @Jibbarth if something sounds wrong to you, let me know. So we can revert it on a fix release.

@nunomaduro nunomaduro merged commit 7aae831 into master Mar 10, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nunomaduro nunomaduro deleted the fix/diffs-displays branch Mar 10, 2020
Copy link
Collaborator

Jibbarth left a comment

LGTM 👍

Copy link
Collaborator

Jibbarth left a comment

LGTM 👍

Copy link
Collaborator

olivernybroe left a comment

Oh wauw, that's a lot of code cleaning 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.