Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ide_helper_models #51

Merged
merged 1 commit into from May 14, 2019

Conversation

@AndreasHerss
Copy link
Contributor

commented May 14, 2019

In addition to #46 it would be nice to ignore the _ide_helper_models.php file too, generated by the same package, as alot of errors are coming from this helper file.

@nunomaduro nunomaduro merged commit dd35301 into nunomaduro:master May 14, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 14, 2019

Thanks!

@AndreasHerss

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

It is me who thanks, for such a nice package! ;)
And, for merging my first pull-request ever to an open-source software 😁

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 14, 2019

This is the kind of pull requests that open source maintainers love. Don't hesitate on doing more contributions like this.

This version v1.0.5 has been tagged with your fix on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.