Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Added padding to percentage string #57

Merged
merged 5 commits into from
May 15, 2019

Conversation

olivernybroe
Copy link
Collaborator

This PR add's padding to the percentage string so the length is always 5

resolves: #22

Copy link
Owner

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pull request! We are almost done, just some few remarks here:

composer.json Outdated Show resolved Hide resolved
src/Application/Console/Style.php Outdated Show resolved Hide resolved
tests/Application/Console/StyleTest.php Show resolved Hide resolved
tests/Application/Console/StyleTest.php Outdated Show resolved Hide resolved
@olivernybroe
Copy link
Collaborator Author

Should have gotten around your comment :)
Just say if you have any other changes you want me to do.

@nunomaduro nunomaduro merged commit 773d826 into nunomaduro:master May 15, 2019
@nunomaduro
Copy link
Owner

Thanks! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.0% Complexity score is not aligned
2 participants