Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Added padding to percentage string #57

Merged
merged 5 commits into from May 15, 2019

Conversation

@olivernybroe
Copy link
Collaborator

commented May 15, 2019

This PR add's padding to the percentage string so the length is always 5

resolves: #22

olivernybroe added some commits May 15, 2019

@nunomaduro
Copy link
Owner

left a comment

Great pull request! We are almost done, just some few remarks here:

Show resolved Hide resolved composer.json Outdated
Show resolved Hide resolved src/Application/Console/Style.php Outdated
Show resolved Hide resolved tests/Application/Console/StyleTest.php
Show resolved Hide resolved tests/Application/Console/StyleTest.php Outdated

olivernybroe added some commits May 15, 2019

@olivernybroe

This comment has been minimized.

Copy link
Collaborator Author

commented May 15, 2019

Should have gotten around your comment :)
Just say if you have any other changes you want me to do.

@nunomaduro nunomaduro merged commit 773d826 into nunomaduro:master May 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 15, 2019

Thanks! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.