Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit status code - #60 #67

Merged
merged 2 commits into from May 16, 2019

Conversation

@Jibbarth
Copy link
Collaborator

commented May 16, 2019

Refs #60 , implements exit status code and min levels to reach.

 $ php bin/phpinsights --help                               
Usage:
  analyse [options] [--] [<directory>]

Arguments:
  directory                                  

Options:
  -c, --config-path[=CONFIG-PATH]            
      --min-quality[=MIN-QUALITY]            Minimal Quality level to reach without throw error [default: 0]
      --min-complexity[=MIN-COMPLEXITY]      Minimal Complexity level to reach without throw error [default: 0]
      --min-architecture[=MIN-ARCHITECTURE]  Minimal Architecture level to reach without throw error [default: 0]
      --min-style[=MIN-STYLE]                Minimal Style level to reach without throw error [default: 0]
  -h, --help                                 Display this help message
  -q, --quiet                                Do not output any message
  -V, --version                              Display this application version
      --ansi                                 Force ANSI output
      --no-ansi                              Disable ANSI output
  -n, --no-interaction                       Do not ask any interactive question
  -v|vv|vvv, --verbose                       Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

Tell me if I should add shortcut, or if information messages should be improved.

@nunomaduro
Copy link
Owner

left a comment

Everything sounds great. Can you also update the docs on this?

@Jibbarth

This comment has been minimized.

Copy link
Collaborator Author

commented May 16, 2019

@nunomaduro I updated the docs 😉

What about the StyleCI issues ? Do you want I fix them ? I personnally found the rules a little bit weird (organise use by length if I understand), but why not ?

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 16, 2019

@Jibbarth Jibbarth referenced this pull request May 16, 2019
@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 16, 2019

Perfect thanks!

@nunomaduro nunomaduro merged commit 3e33728 into nunomaduro:master May 16, 2019

1 of 2 checks passed

continuous-integration/styleci/pr Issues have been identified with 4 files
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Jibbarth Jibbarth deleted the Jibbarth:feature/error-status-code branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.