Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exclusion of files with a path #75

Merged
merged 3 commits into from Jun 5, 2019
Merged

Allow exclusion of files with a path #75

merged 3 commits into from Jun 5, 2019

Conversation

@Pluiesurlavitre
Copy link
Contributor

@Pluiesurlavitre Pluiesurlavitre commented May 16, 2019

Allows to exclude files and directories like so:

  • Folder/SubFolder
  • Folder/SubFolder/Class.php
Copy link
Collaborator

@Jibbarth Jibbarth left a comment

👍 for tests.

Loading

src/Infrastructure/Repositories/LocalFilesRepository.php Outdated Show resolved Hide resolved
Loading
tests/Application/LocalFilesRepositoryTest.php Outdated Show resolved Hide resolved
Loading
src/Infrastructure/Repositories/LocalFilesRepository.php Outdated Show resolved Hide resolved
Loading
Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Looks good to me. Seems like notPath gives us a lot of advantages.

Loading

@nunomaduro
Copy link
Owner

@nunomaduro nunomaduro commented Jun 4, 2019

@olivernybroe Hey buddy! Thanks for validating this, there is no breaking changes?

Loading

@nunomaduro
Copy link
Owner

@nunomaduro nunomaduro commented Jun 4, 2019

@Jibbarth There is no breaking changes on this?

Loading

@Jibbarth
Copy link
Collaborator

@Jibbarth Jibbarth commented Jun 4, 2019

@nunomaduro No, it's ok.

Loading

@olivernybroe
Copy link
Collaborator

@olivernybroe olivernybroe commented Jun 5, 2019

@nunomaduro No breaking cases. Only maybe in some really edge cases with folder naming matching a regex.

Loading

@nunomaduro nunomaduro merged commit cff9a41 into nunomaduro:master Jun 5, 2019
1 check failed
Loading
@nunomaduro
Copy link
Owner

@nunomaduro nunomaduro commented Jun 5, 2019

Thanks for this folks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants