Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exclusion of files with a path #75

Merged
merged 3 commits into from Jun 5, 2019

Conversation

@Sixine
Copy link
Contributor

commented May 16, 2019

Allows to exclude files and directories like so:

  • Folder/SubFolder
  • Folder/SubFolder/Class.php
@Jibbarth
Copy link
Collaborator

left a comment

👍 for tests.

@Sixine Sixine force-pushed the Sixine:develop branch 3 times, most recently from 53b0d4e to a66dfbd Jun 4, 2019

Sixine added some commits May 21, 2019

Exclude files without breaking BC
Add regex tests

@Sixine Sixine force-pushed the Sixine:develop branch from a66dfbd to 24afdf3 Jun 4, 2019

@olivernybroe
Copy link
Collaborator

left a comment

Looks good to me. Seems like notPath gives us a lot of advantages.

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

@olivernybroe Hey buddy! Thanks for validating this, there is no breaking changes?

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

@Jibbarth There is no breaking changes on this?

@Jibbarth

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

@nunomaduro No, it's ok.

@olivernybroe

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

@nunomaduro No breaking cases. Only maybe in some really edge cases with folder naming matching a regex.

@nunomaduro nunomaduro merged commit cff9a41 into nunomaduro:master Jun 5, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@nunomaduro

This comment has been minimized.

Copy link
Owner

commented Jun 5, 2019

Thanks for this folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.