Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #70 #76

Merged
merged 1 commit into from May 16, 2019

Conversation

@Jibbarth
Copy link
Collaborator

commented May 16, 2019

Check if composer require is setted and contains an array
Add tests on ConfigResolver::guess

@nunomaduro
Copy link
Owner

left a comment

Tests are good, I would just adapt the implementation.

src/Application/ConfigResolver.php Outdated Show resolved Hide resolved

@Jibbarth Jibbarth force-pushed the Jibbarth:fix/issue-70-check-composer branch from f5937c2 to c6cca50 May 16, 2019

Fix issue #70
Check if composer require is setted and contains an array in differents Frameworks Presets
Add tests on ConfigResolver::guess

@Jibbarth Jibbarth force-pushed the Jibbarth:fix/issue-70-check-composer branch from c6cca50 to 318f429 May 16, 2019

@nunomaduro nunomaduro merged commit c10cb24 into nunomaduro:master May 16, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 16, 2019

It's perfect. Thanks!

@Jibbarth Jibbarth deleted the Jibbarth:fix/issue-70-check-composer branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.