Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require necessary extension #90

Merged
merged 1 commit into from May 17, 2019

Conversation

@deleugpn
Copy link
Contributor

commented May 17, 2019

Addresses #72. nette/utils doesn't explicit require it because they provide too many things, but they do suggest it (https://github.com/nette/utils/blob/master/composer.json#L25). Since it's part of the core process of Insight to use Strings::webalize, it makes sense for Insights to require it on installation time instead of delegating to Runtime since Insights cannot work at all without it.

@nunomaduro nunomaduro merged commit 0ab7491 into nunomaduro:master May 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 17, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.