New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for table tags #54
Add support for table tags #54
Conversation
I've completely forgot about table properties. has one of symfony table styles. See https://github.com/symfony/console/blob/5.3/Helper/Table.php#L843I added also support for colspan, rowspan |
Awesome, Thanks @butschster. |
- header and footer title - row separator - tfoot - th tag will add bold style for text
I've just added couple of new features and also replaced table. I got an example from symfpny docs |
Now you can use <tr border="1">, <tr border="2">, ... Added ability to configure title for header and footer. <thead title="Books" class="bg-red text-color-white px-10"> <tfoot title="Page 1/2" class="mx-5 bg-blue">
I've just added some of useful features.
<tr border="2">
...
</tr>
Now you can use class attribute for <thead title="Books" class="bg-red text-color-white px-10">
...
</thead> <tfoot title="Page 1/2" class="mx-5 bg-blue">
...
</tfoot> |
Great printscreen haha 👌 |
It's figma :) I liked your one. |
# Conflicts: # tests/render.php
Made it to be a draft since you are still working, on it. also keep in mind if pull request #60 is merged you may need to rebase. Keep up the good work! thanks @butschster. |
Oh, I didn't notice your message. Ok, I'll rebase last commits soon |
@xiCO2k done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, only those two tweaks I mention. Thanks
Looks good to me. @nunomaduro can you take a look on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the changes on the readme, and you can merge this @xiCO2k .
Done |
Will render