-
Notifications
You must be signed in to change notification settings - Fork 0
Added canary rollout docs #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0d29728 to
078842a
Compare
| ```text | ||
| LAST SEEN TYPE REASON OBJECT MESSAGE | ||
| 22m Normal CanaryPauseStep CanaryRollout/acme-upgrade Pause step (1/13) activated: canary rollout paused until manual approval | ||
| 21m Normal CanaryManuallyApproved CanaryRollout/acme-upgrade Pause step (1/13) manually approved after -1h59m59.509203822s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It is a bit silly that the pause duration was negative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. This is a side-effect from replacing the Paused condition instead of just changing its reason. To avoid this, we need to remember the LastTransitionTime before resetting the condition on manual approval. This is just a visual issue but I will remove this line to avoid confusion.
078842a to
d285dbb
Compare
kontaras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes I asked for.
| The example is simplified and has one Helm feature, one service tier, and two databases for demonstration purposes. | ||
| Multiple controllers in the NuoDB operator are responsible for progressively rolling out the change in the Helm feature to both databases. | ||
|
|
||
| {{< picture src="canary-success-flow.png" alt="Canary rollout success flow" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible for this image to be expandable by clicking on it? In the rendered page, it appears very small and I have to open it in a separate window to be able to zoom in and read the labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modified the figure shortcode to add a link to the image which by default opens up in the _self target.
adriansuarez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Changes
Added canary rollout docs - here.