Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requirements.txt or Pipfile #27

Closed
adtya opened this issue Mar 2, 2019 · 7 comments
Closed

add requirements.txt or Pipfile #27

adtya opened this issue Mar 2, 2019 · 7 comments
Labels
easy enhancement New feature or request gssoc19

Comments

@adtya
Copy link
Contributor

adtya commented Mar 2, 2019

currently, the only option to install and manage the dependencies is by using the setup.py. It'll be easier to manage the dependencies by having a requirements.txt or Pipfile

@inishchith
Copy link
Collaborator

@adtyanair Any progress with this?

@adtya
Copy link
Contributor Author

adtya commented Mar 3, 2019

I was able to add all the dependencies in the setup.py file using pipenv and Pipfile. I verified this by running pip install -e . which shows requirement already satisfied. But to run the program, it is required to install it to the system and this installs the dependencies anyways.

Also, I looked through some other similar python packages and none of them seems to have a Pipfile. so I'm still researching on this.

@inishchith
Copy link
Collaborator

@adtyanair Yes, I've had a thought over this. I feel it's be better if we control the versions of dependencies right from setup.py.

I'd really appreciate if you can update the setup.py file instead with current versions of the dependencies. I missed this out. Apologies for the late revert.

Let me know what you think

@inishchith
Copy link
Collaborator

@adtyanair any updates on this?

@inishchith inishchith added enhancement New feature or request easy gssoc19 labels Mar 15, 2019
@adtya
Copy link
Contributor Author

adtya commented Mar 28, 2019

as of now, the dependency versions are not provided and available latest versions are being installed. This could break something if a breaking change is added to any of the dependencies.

At the moment the following versions are being installed(on Linux) and drive seems to work properly with these:

click [required: Any, installed: 7.0]
colorama [required: Any, installed: 0.4.1]
google-api-python-client [required: Any, installed: 1.7.8]
httplib2 [required: Any, installed: 0.12.1]
oauth2client [required: Any, installed: 4.1.3]
pick [required: Any, installed: 0.6.4]
prettytable [required: Any, installed: 0.7.2]
pyfiglet [required: Any, installed: 0.8.post1]
requests [required: Any, installed: 2.21.0]

Should I fix these versions for the dependencies?

@inishchith
Copy link
Collaborator

inishchith commented Apr 1, 2019

@adtyanair Sorry for addressing your comments lately.
Sure, Go ahead.
Thanks :)

@adtya
Copy link
Contributor Author

adtya commented Apr 4, 2019

I have created a pull request. But I was not able to do anything about the requirement 'windows-curses' because I don't have a windows system with me. It would be nice if someone with a windows system could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement New feature or request gssoc19
Projects
None yet
Development

No branches or pull requests

3 participants