New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BASIC exporter should export the active screen, not the first in the list #78

Closed
Esshahn opened this Issue Aug 12, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@Esshahn
Collaborator

Esshahn commented Aug 12, 2018

It seem that the BASIC exporter always chooses the first screen to export when there are multiple ones. It would be better if it exports the current visible/selected one instead.

Otherwise one would need to delete all screens that are one the left side of the thumbnails to export the current screen.

Scenario below exports the first screen, not the second one with the white border

screenshot 2018-08-12 um 12 02 24

@Esshahn Esshahn added this to the 0.4 milestone Aug 12, 2018

@nurpax nurpax added the bug label Aug 12, 2018

@nurpax

This comment has been minimized.

Show comment
Hide comment
@nurpax

nurpax Aug 12, 2018

Owner

It was intended to export the currently selected screen, so definitely a bug.

Owner

nurpax commented Aug 12, 2018

It was intended to export the currently selected screen, so definitely a bug.

@nurpax

This comment has been minimized.

Show comment
Hide comment
@nurpax

nurpax Aug 12, 2018

Owner

OK, here's the bug:

const saveBASIC = (filename, fbs, options) => {
  try {
    let lines = []
    // Single screen export
    convertToBASIC(lines, fbs[options.selectedFramebufIndex], 0)

    let backgroundColor
    let borderColor
    if (fbs.length >= 1) {
      backgroundColor = fbs[0].backgroundColor
      borderColor = fbs[0].borderColor
    }

I think I originally exported all the frames and then later decided to export just one. And ehh brainfart^Wrefactored it to pick the wrong border/bg colors.

Owner

nurpax commented Aug 12, 2018

OK, here's the bug:

const saveBASIC = (filename, fbs, options) => {
  try {
    let lines = []
    // Single screen export
    convertToBASIC(lines, fbs[options.selectedFramebufIndex], 0)

    let backgroundColor
    let borderColor
    if (fbs.length >= 1) {
      backgroundColor = fbs[0].backgroundColor
      borderColor = fbs[0].borderColor
    }

I think I originally exported all the frames and then later decided to export just one. And ehh brainfart^Wrefactored it to pick the wrong border/bg colors.

@nurpax

This comment has been minimized.

Show comment
Hide comment
@nurpax

nurpax Aug 12, 2018

Owner

Same bug in .asm export too. Fix incoming.

Owner

nurpax commented Aug 12, 2018

Same bug in .asm export too. Fix incoming.

@nurpax nurpax closed this in 49cc081 Aug 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment