Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat][sc-45108] Improve logging and handle delete-during-wait edge case #1

Merged
merged 1 commit into from Mar 14, 2023
Merged

[Feat][sc-45108] Improve logging and handle delete-during-wait edge case #1

merged 1 commit into from Mar 14, 2023

Conversation

bericp1
Copy link

@bericp1 bericp1 commented Mar 14, 2023

Description

  • Need to handle the case where the stack is actively deleting before we start waiting on it. Just like if the stack doesn't exist when we start, if it's deleted while we're waiting, that can be considered a "ready" state
  • Improve logging and make it more legible and detailed.

Proof of Functionality

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #45108: Ensure waiting on a deleting stack works in @vivianhealth/aws-cloudformation-wait-ready + add timeout option.

@bericp1 bericp1 requested review from a team, thelinuxkid, econner and jf-strength and removed request for a team and thelinuxkid March 14, 2023 21:40
NitaelDuque
NitaelDuque approved these changes Mar 14, 2023
View reviewed changes
Copy link

@NitaelDuque NitaelDuque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bericp1
Copy link
Author

bericp1 commented Mar 14, 2023

LGTM

Thanks for jumping on!

@bericp1 bericp1 merged commit efcfc0e into main Mar 14, 2023
1 check passed
@bericp1 bericp1 deleted the feature/sc-45108/ensure-waiting-on-a-deleting-stack-works branch March 14, 2023 22:24
@vivian-infra-bot
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NitaelDuque NitaelDuque NitaelDuque approved these changes

@econner econner Awaiting requested review from econner econner was automatically assigned from nursefly/infrastructure

@jf-strength jf-strength Awaiting requested review from jf-strength

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
3 participants
@bericp1 @vivian-infra-bot @NitaelDuque