[Nguyen Dang Phuc Nhat] Duke A-Assertions A-CodeQuality C-BetterSearch #167

NNpanpan · 2020-01-29T13:50:24Z

No description provided.

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S2#9)

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Add configuration for console applications

The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.

Code looks like a shamble, but meh

RubaP

Please go through the detailed comments. Avoid adding trivial comments and commented code segemnts in future work.

RubaP · 2020-02-09T11:28:18Z

bin/input.txt

@@ -0,0 +1,17 @@
+todo borrow book


You can .class files to the gitignore files so that complied files will be ignored

RubaP · 2020-02-09T11:29:08Z

src/main/java/duke/exception/InvalidCommandException.java

+     * @param msg
+     */
+    public InvalidCommandException(String msg) {
+        super(String.format("'%s' is an invalid command", msg));


You can define these messages as constant variables

RubaP · 2020-02-09T11:29:30Z

src/main/java/duke/exception/OutOfBoundMarkingRequestException.java

+/**
+ * Indicates that an index is out of bound
+ */
+public class OutOfBoundMarkingRequestException extends Exception {


Good that you have very specific Exceptions defined

RubaP · 2020-02-09T11:30:07Z

src/main/java/duke/main/Duke.java

+    public static final String LIST_COMMAND = "list";
+    public static final String BYE_COMMAND = "bye";
+
+    //    private static String PADDING = "       ";


Please remove commented code

RubaP · 2020-02-09T11:31:05Z

src/main/java/duke/main/Duke.java

+    private Parser parser;
+
+    /**
+     * Constructor


You can avoid trivial information in the comment.

RubaP · 2020-02-09T11:32:55Z

src/main/java/duke/task/Deadline.java

+    }
+
+    /**
+     * Stringify the object


Same here. It should be Strigifies xxx

RubaP · 2020-02-09T11:33:26Z

src/main/java/duke/task/Task.java

+    protected boolean isDone;
+
+    /**
+     * Constructor with a name


Please avoid trivial information in the comments

RubaP · 2020-02-09T11:36:11Z

src/main/java/duke/util/Storage.java

+    }
+
+    /**
+     * Read all data in filePath and turn them into tasks in storedItems


Same here. It should be Reads xxx

RubaP · 2020-02-09T11:36:42Z

src/main/java/duke/util/TaskList.java

+     * @param storedItems
+     * @throws OutOfBoundMarkingRequestException
+     */
+    public static String markItemAsDone(int pos, ArrayList<Task> storedItems) throws OutOfBoundMarkingRequestException {


Make the variable names more descriptive e.g. position

RubaP · 2020-02-09T11:37:06Z

src/main/java/duke/util/ui/Ui.java

+//        System.out.println(String.format("%s%s", PADDING, USELESS_LINE));
+//        System.out.println(String.format("%sGreetings! This is %s, and I am your friend!", PADDING, BOT_NAME));
+//        System.out.println(String.format("%sYou don't have to be formal. Relax and tell me how I can help you", PADDING));
+//        System.out.println(String.format("%s%s", PADDING, USELESS_LINE));


Please remove the commented code

Should be satisfactory for now...

j-lum and others added 30 commits August 6, 2019 15:25

Add support for Gradle workflow

65f72a8

Add sample checkstyle configuration

0112efe

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on gradle to be executable

cfd6da7

Merge pull request nus-cs2103-AY1920S2#12 from j-lum/gradle+x

6e6ace1

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S2#9)

Add configuration for console applications

a3ca5a4

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Merge pull request nus-cs2103-AY1920S2#13 from j-lum/javaexec

7b60e81

Add configuration for console applications

JavaFX tutorial: Support cross-platform JARs

c4678f7

The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.

JavaFX tutorial: Support cross-platform JARs [nus-cs2103-AY1920S2#16]

30efbae

Created Main

35444b9

Finished Level-1

8eb2d23

Really finished Level-1

eed4449

Level 2

7697e77

Level 2 fixed with longer uselessLine

232c651

Handle empty input lvl 2

9a10d6b

May have really finished level 2

ab11b61

Added Task class

996cc8d

Level 3 without catching errors... But do we need to?

38acbd4

Created classes for 3 task types

c138881

Basic code for 3 types

b0cee96

Added method to check command type

2d90a11

handleToDo

4be6e85

Level 4 seems done

1f6d789

Created runtest.sh

e3930ab

Tried semi-auto testing with redirection

266b166

InvalidCommandException added

1860c37

Added OutOfBoundMarkingException

7dd1d9f

Handled 2 exceptions

25cc547

Seems like some visible errors are handled

1244ec3

Level 6 seems okay

53dda83

Save feature

ed04c13

This was referenced Feb 4, 2020

Feedback on week 4 project progress for syinyichen syinyichen/duke#3

Open

Feedback on week 4 project progress for hanchingyong hanchingyong/duke#3

Open

NNpanpan added 2 commits February 5, 2020 23:56

fmxl added, code looks shamble

d60cc9e

Merge branch 'Level-10'

739f545

Code looks like a shamble, but meh

nus-se-bot mentioned this pull request Feb 5, 2020

Feedback on week 4 project progress for xinpei-ng XinPei-ng/duke#4

Closed

5 tasks

RubaP reviewed Feb 9, 2020

View reviewed changes

NNpanpan added 5 commits February 9, 2020 20:55

Clean up

7ea3306

made another jar

27c6edb

Asserts

5ab2658

quality

99701a8

slightly better search

05a9c9a

NNpanpan changed the title ~~[Nguyen Dang Phuc Nhat] Duke Increments~~ [Nguyen Dang Phuc Nhat] Duke A-Assertions A-CodingQuality C-BetterSearch Feb 13, 2020

NNpanpan changed the title ~~[Nguyen Dang Phuc Nhat] Duke A-Assertions A-CodingQuality C-BetterSearch~~ [Nguyen Dang Phuc Nhat] Duke A-Assertions A-CodeQuality C-BetterSearch Feb 13, 2020

NNpanpan added 16 commits February 18, 2020 20:41

Fixing some UI issues

e649011

Resize screen

2136461

UG

0667c35

Set theme jekyll-theme-architect

c12712e

Set theme jekyll-theme-tactile

fd07bf1

update README.md

e3f2d7b

Merge branch 'master' of https://github.com/NNpanpan/duke

0a1d8aa

more update

d699bc3

more update

973750c

Set theme jekyll-theme-cayman

97bb946

fixed page

a30370f

Update README.md

5892193

changed pic

ea8a4cf

gradle issue

38a75d0

Update README.md

02ca57a

Update README.md

6bbdb38

Should be satisfactory for now...

NNpanpan closed this Feb 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Nguyen Dang Phuc Nhat] Duke A-Assertions A-CodeQuality C-BetterSearch #167

[Nguyen Dang Phuc Nhat] Duke A-Assertions A-CodeQuality C-BetterSearch #167

NNpanpan commented Jan 29, 2020

RubaP left a comment •

edited

Loading

RubaP Feb 9, 2020

RubaP Feb 9, 2020

RubaP Feb 9, 2020

RubaP Feb 9, 2020

RubaP Feb 9, 2020

RubaP Feb 9, 2020

RubaP Feb 9, 2020

RubaP Feb 9, 2020

RubaP Feb 9, 2020

RubaP Feb 9, 2020

[Nguyen Dang Phuc Nhat] Duke A-Assertions A-CodeQuality C-BetterSearch #167

[Nguyen Dang Phuc Nhat] Duke A-Assertions A-CodeQuality C-BetterSearch #167

Conversation

NNpanpan commented Jan 29, 2020

RubaP left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RubaP left a comment •

edited

Loading