[cleowenxuan] iP #360

cleowenxuan · 2024-02-01T07:36:59Z

Asher 🤖

"Either you run the day or the day runs you." - Jim Rohn
source

Allow Asher to help you remember the things you need to do! It is,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here
double-click it.
add your tasks.
let it manage your tasks for you.

And it is FREE!

Features:

Manage your todos! 📚
Manage deadlines 🖥️
Manage events 📆
Reminders ⏳ (coming soon)

If you are a Java programmer, you can use it to practice Java too. Here is the main method:

    public static void main(String[] args) {
        String dataFile = "./taskLists.txt";
        new Asher(dataFile).run();
    }

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Merge Level8 with master.

ruijietay

Generally, great job following the coding standards! However, I feel that it would be better to have whitespaces between certain characters such as operators and braces. I believe it would help in ensuring your code follows a coding standard by installing the checkstyle plugin on IntellJ! 😄

ruijietay · 2024-02-05T13:10:50Z

src/main/java/Asher.java

+        try {
+            File file = new File(filePath);
+            if (!file.exists()) {
+                boolean created = file.createNewFile();


Should this be renamed with a prefix preceding the boolean variable created?

ruijietay · 2024-02-05T13:26:21Z

src/main/java/Asher.java

+import java.util.Scanner;
+import java.util.List;
+import java.util.ArrayList;
+import java.time.LocalDate;
+import java.time.LocalTime;


Would it be better to have the import statements be in alphabetical order?

ruijietay · 2024-02-05T13:35:35Z

src/main/java/Event.java

+    @Override
+    public String writeToString() {
+        String status = isDone ? "1" : "0";
+        return "E" + " | " + status + " | " + description + " | " + startDate + " | " + startTime + " | " + endDate + " | " + endTime;


Would this be better if it was split into two lines?

ruijietay · 2024-02-05T13:37:17Z

src/main/java/Asher.java

+        if (taskNumber != -1) {
+            tasks.get(taskNumber).markDone();
+            System.out.println("Nice! I've marked this task as done:");
+            System.out.println(" "  + tasks.get(taskNumber));


Should the extra space between " " and + be removed?

Merge branch A-MoreOOP with the master.

Merging add-gradle-support with master.

Merge Java Doc branch with the master.

PateShin

Codes are mostly conforms to the Code Quality: Naming standards Great job 👍
There are just a few minor issues and suggestions that could be improved.

PateShin · 2024-02-08T15:32:01Z

src/main/java/asher/Commands/Storage.java

+     * @param tasks The List of tasks.
+     */
+
+    public void getFileContents(String filePath, TaskList tasks) {


Consider to remove the String filePath as class variable is used, not a parameter.

PateShin · 2024-02-08T15:32:19Z

src/main/java/asher/Asher.java

+     */
+    public void run() {
+        String dataFile = "./taskLists.txt";
+        storage.getFileContents(dataFile, tasks);


Perhaps consider usinggetFileTasks as tasks are scanned from .txt file.

PateShin · 2024-02-08T15:33:31Z

src/main/java/asher/Tasks/Deadline.java

+    }
+
+    @Override
+    public String writeToString() {


Consider renaming toFileStringFormat to be more descriptive.

PateShin · 2024-02-08T15:44:50Z

src/main/java/asher/Ui/Ui.java

+     * Displays the number of tasks in the list message.
+     * @param totalTasks The total number of tasks.
+     */
+    public void showNumberOfTaskInListMessage(int totalTasks) {


I like how you described the function with its name

PateShin · 2024-02-08T15:51:43Z

src/main/java/asher/Tasks/Event.java

+        DateTimeFormatter formattingDate = DateTimeFormatter.ofPattern("MMM dd yyyy");
+        DateTimeFormatter formattingTime = DateTimeFormatter.ofPattern("hh:mm a");


I like how you named them. Perhaps try DateFormatted and FormattedTime?

Some codes do not follow the coding standard. Refactor the packages in the asher package to follow the package naming convention. Refactor the java files inside test.java.asher to follow the class naming convention. Rephrase method/class header comments to follow the format specified in the coding standard. Java Docs are being added to most methods and classes for clarity.

Merge the branch branch-A-Assertions with master.

Merge the branch branch-A-CodeQuality with master.

damithc and others added 16 commits January 7, 2024 18:33

docs/README.md: Tweak document template

55f9f9f

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Add Gradle support

f837ddb

Bump gradle and lib version

a6f7324

Level0 Completed

a3bdb36

Level1 Completed

8c162fb

Level2 Completed

85640cf

Level3 Completed

9e51482

Level4 Completed

2f2f863

Automated Text UI Testing Completed

4cb21f3

Level 5 Completed

d00780c

Level 6 Completed

0938515

Final Touches

3868c11

Level 7 Completed

b572136

Merge branch 'branch-Level-7'

e07e970

Level 8 Completed

9eeaacd

Merge branch 'branch-Level-8'

6cfcced

Merge Level8 with master.

ruijietay reviewed Feb 5, 2024

View reviewed changes

cleowenxuan added 13 commits February 7, 2024 18:21

A-MoreOOP Completed

803a0ff

Merge branch 'A-MoreOOP'

6fe0489

Merge branch A-MoreOOP with the master.

A-Packages Completed

3dd8e1d

Merge branch 'add-gradle-support'

14919e1

Merging add-gradle-support with master.

A-Gradle Completed

3340fd6

A-JUnit Completed

5765cc0

A-Jar Completed

8a6a61a

A-JavaDoc Completed

096f3cb

Merge branch 'branch-A-JavaDoc'

73a3a9a

Merge Java Doc branch with the master.

A-CodingStandard Completed

cb8d0ae

Resolve Conflicts between CodingStandard branch and JavaDoc branch

7512431

Level 9 Completed

9f5be35

Resolve Conflicts with Level-9 and master

5dba628

PateShin reviewed Feb 8, 2024

View reviewed changes

cleowenxuan and others added 20 commits February 12, 2024 18:57

JavaFX Tutorial Guide

572ce7d

Level-10 Completed, has some minor bugs

5b58ec2

Resolve issues with merging branch-Level-10

584a7de

A-Assertions Completed

12b7ac2

Merge pull request #2 from cleowenxuan/branch-A-Assertions

c91a431

Merge the branch branch-A-Assertions with master.

Merge branch 'master' into branch-A-CodeQuality.

25f93f2

Merge pull request #3 from cleowenxuan/branch-A-CodeQuality

3a6226c

Merge the branch branch-A-CodeQuality with master.

BCD-Extensions Completed

83c5b72

Merge branch 'branch-BCD-Extension'

da0d301

User Guide Completed

346fb87

Fix get file content issue

f9bff00

Fix issues regarding DialogBox.java

4a7c128

Modify the extension into a command instead of sorting at TaskList

be28a7a

A-AiAssisted Completed

e9c88c2

Modify User Guide

ac1a111

Add Ui.png

fc73f5d

Fix bugs for DialogBox

d7e2ff3

Fix minor bugs

2acb5f0

Fix exception bugs

c4979da

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cleowenxuan] iP #360

[cleowenxuan] iP #360

cleowenxuan commented Feb 1, 2024 •

edited

Loading

ruijietay left a comment

ruijietay Feb 5, 2024

ruijietay Feb 5, 2024

ruijietay Feb 5, 2024

ruijietay Feb 5, 2024

PateShin left a comment

PateShin Feb 8, 2024

PateShin Feb 8, 2024

PateShin Feb 8, 2024

PateShin Feb 8, 2024

PateShin Feb 8, 2024

		DateTimeFormatter formattingDate = DateTimeFormatter.ofPattern("MMM dd yyyy");
		DateTimeFormatter formattingTime = DateTimeFormatter.ofPattern("hh:mm a");

[cleowenxuan] iP #360

Are you sure you want to change the base?

[cleowenxuan] iP #360

Conversation

cleowenxuan commented Feb 1, 2024 • edited Loading

Asher 🤖

ruijietay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PateShin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cleowenxuan commented Feb 1, 2024 •

edited

Loading