From 43ceb3edec4ad591e6ef500cf66492671a804de7 Mon Sep 17 00:00:00 2001 From: Stefan Holderbach Date: Mon, 21 Aug 2023 00:08:49 +0200 Subject: [PATCH] Remove clippy global `-A` from CI (#10072) # Description We allowed two default lints due to false positives. This should be locally addressed with explicit information what causes either a false positive or why a particular design choice in the code is made. # User-Facing Changes None # Tests + Formatting We should detect a few more things with clippy out of the box. If you encounter a false positive you will need to address it on a case by case basis. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 94adb2099060..9577eb0425d3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,7 @@ name: continuous-integration env: NUSHELL_CARGO_TARGET: ci NU_LOG_LEVEL: DEBUG - CLIPPY_OPTIONS: "-D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err" + CLIPPY_OPTIONS: "-D warnings -D clippy::unwrap_used" jobs: fmt-clippy: