diff --git a/crates/nu-lsp/src/lib.rs b/crates/nu-lsp/src/lib.rs index 020c4e5f7c42..61f5968713c5 100644 --- a/crates/nu-lsp/src/lib.rs +++ b/crates/nu-lsp/src/lib.rs @@ -964,7 +964,7 @@ mod tests { } #[test] - fn hover_on_command() { + fn hover_on_custom_command() { let (client_connection, _recv) = initialize_language_server(); let mut script = fixtures(); @@ -993,6 +993,36 @@ mod tests { ); } + #[test] + fn hover_on_str_join() { + let (client_connection, _recv) = initialize_language_server(); + + let mut script = fixtures(); + script.push("lsp"); + script.push("hover"); + script.push("command.nu"); + let script = Url::from_file_path(script).unwrap(); + + open_unchecked(&client_connection, script.clone()); + + let resp = hover(&client_connection, script.clone(), 5, 8); + let result = if let Message::Response(response) = resp { + response.result + } else { + panic!() + }; + + assert_json_eq!( + result, + serde_json::json!({ + "contents": { + "kind": "markdown", + "value": "Concatenate multiple strings into a single string, with an optional separator between each.\n### Usage \n```\n str join {flags} \n```\n\n### Flags\n\n `-h`, `--help` - Display the help message for this command\n\n\n### Parameters\n\n `separator: string` - Optional separator to use when creating string.\n\n\n### Input/output types\n\n```\n list | string\n string | string\n\n```\n### Example(s)\n Create a string from input\n```\n ['nu', 'shell'] | str join\n```\n Create a string from input with a separator\n```\n ['nu', 'shell'] | str join '-'\n```\n" + } + }) + ); + } + fn complete(client_connection: &Connection, uri: Url, line: u32, character: u32) -> Message { client_connection .sender diff --git a/src/ide.rs b/src/ide.rs index 399c6578a0e4..f65fb882184e 100644 --- a/src/ide.rs +++ b/src/ide.rs @@ -211,8 +211,7 @@ pub fn hover(engine_state: &mut EngineState, file_path: &str, location: &Value) Some((Id::Declaration(decl_id), offset, span)) => { let decl = working_set.get_decl(decl_id); - //let mut description = "```\n### Signature\n```\n".to_string(); - let mut description = "```\n".to_string(); + let mut description = String::new(); // first description description.push_str(&format!("{}\n", decl.usage())); diff --git a/tests/fixtures/lsp/hover/command.nu b/tests/fixtures/lsp/hover/command.nu index 14a1196d001e..688eaf5f177b 100644 --- a/tests/fixtures/lsp/hover/command.nu +++ b/tests/fixtures/lsp/hover/command.nu @@ -2,3 +2,5 @@ def hello [] {} hello + +[""] | str join