Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP #2 - 'chsh' and command cleanup #261

Open
jonathandturner opened this issue Aug 8, 2019 · 6 comments

Comments

@jonathandturner
Copy link
Collaborator

commented Aug 8, 2019

"chsh" and standardize commands

This is the plan for the 2nd MVP. See #122 for the 1st planned MVP.

Essentials

  • should be able to chsh (related to #80)
  • Commands/plugins calling each other (#180)
  • command argument shortforms
  • help
  • less functionality for printing large tables or trees
  • Environment variable support (needs mini-design)
  • && separator
  • non-X11 Linux mode (#322)
  • Stability fixes/catch panics (#294)
  • Survey all unwraps. (#300)
  • Return errors instead of panicking
  • catch all panics

Nice-to-haves

  • paths from $it (eg $it.authors)
    • for internal commands
    • for external commands
  • better match command (eg match "{first name} {last name}")
  • Some sort of video
@jonathandturner jonathandturner referenced this issue Aug 8, 2019
18 of 18 tasks complete
@jonathandturner jonathandturner pinned this issue Aug 15, 2019
@jonathandturner jonathandturner changed the title MVP #2 Tracking issue Release #2 - 'chsh' and command cleanup Aug 15, 2019
@jonathandturner jonathandturner changed the title Release #2 - 'chsh' and command cleanup MVP #2 - 'chsh' and command cleanup Aug 15, 2019
@ijt

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

chsh already works for me with nu on Linux:

Screen Shot 2019-08-24 at 6 20 25 PM

and on Mac (had to edit /etc/shells first). Is there something more to it than that?

@jonathandturner

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 25, 2019

@ijt the basic stuff works though you might run into problems when you try to access commands in your path or work with environment variables. These are a few things (plus stability) we're hoping to get done for the next release.

@ijt

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

@BatmanAoD

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

I notice that "environment variable support" is listed here, but "variables" is also an item in the Release #4 checklist. Is the intent to make environment variables separate from scripting variables in some way?

@jonathandturner

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 29, 2019

@ijt - I just tried chsh for Nu on my Pop! OS Linux box, and it seems to mostly "just work". It appears to do this by spawning a sh to start Nu from, which gives access to the path and environment variables. This may mean that some distros can run in this mode while others may need more complete support.

@ijt

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.