Consolidate and fix closure parameter handling#16844
Merged
Merged
Conversation
nome
force-pushed
the
closures
branch
3 times, most recently
from
77cdf2e to
a6c64e9
Compare
Make `do` use the same closure calling logic as all other builtin commands. Implement handling of optional parameters, default parameter values and parameter type checking in the common closure calling logic, which was previously only implemented for `do`. Fix handling of rest parameters. Fixes nushell#16179
Refactor command call handling to avoid code duplication with closure calls.
Bahex
approved these changes
Apr 23, 2026
Member
|
Sorry for taking so long to review and land it. This was a much needed refactor, thank you! |
cptpiepmatz
added
notes:mention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do)....restparameter to a command likeitemsused to have a bug, where only the last argument was given to the closure instead of a list of all arguments.do, now apply to all commands that take a closure. Consequently, there may be some corner cases where code that previously ran is now rejected.ClosureEval::add_argnow returns aResult).Release notes summary - What our users need to know
Tasks after submitting