Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some search-terms to the platform category #7021

Merged
merged 3 commits into from Nov 6, 2022
Merged

added some search-terms to the platform category #7021

merged 3 commits into from Nov 6, 2022

Conversation

1Kinoti
Copy link
Contributor

@1Kinoti 1Kinoti commented Nov 6, 2022

Description

Add some search terms to the platform category

command search-terms(s)
kill stop, end, close
sleep delay, wait, sleep, timer
ansi text-color, text-style, colors
ansi gradient gradients

Contributes to issue #5093

Tests + Formatting

Make sure you've done the following, if applicable:

  • Add tests that cover your changes (either in the command examples, the crate/tests folder, or in the /tests folder)
    • Try to think about corner cases and various ways how your changes could break. Cover those in the tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all tests pass

User-Facing Changes

If you're making changes that will affect the user experience of Nushell (ex: adding/removing a command, changing an input/output type, adding a new flag):

@fdncred
Copy link
Collaborator

fdncred commented Nov 6, 2022

Thanks for this.

I think the CI is complaining about search terms that we don't need. For example, if the command is called sleep, we don't need a search term called sleep because it's already searched with the command name.

@1Kinoti
Copy link
Contributor Author

1Kinoti commented Nov 6, 2022

I guess I should remove them then?

@fdncred
Copy link
Collaborator

fdncred commented Nov 6, 2022

I guess I should remove them then?

yes, hopefully that'll make the ci green.

@sholderbach
Copy link
Member

Thanks for the quick turnaround!

@sholderbach sholderbach merged commit 8a812cf into nushell:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants