Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit rm help messages #7165

Merged
merged 2 commits into from Nov 19, 2022
Merged

Edit rm help messages #7165

merged 2 commits into from Nov 19, 2022

Conversation

webbedspace
Copy link
Contributor

Description

Splitoff from #6983. This tweaks rm's help messages for grammar and readability.

Also, this adds a test showing a slightly more complex rm use-case.

User-Facing Changes

See above.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@rgwood
Copy link
Contributor

rgwood commented Nov 19, 2022

Nice, thanks. Think a couple rm_always_trash mentions in the examples should be replaced with always_trash, otherwise LGTM.

@rgwood rgwood merged commit 587536d into nushell:main Nov 19, 2022
@webbedspace webbedspace deleted the rm-help-msgs branch November 20, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants