Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to handling of incoming events #179

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Conversation

sholderbach
Copy link
Member

To avoid issues with incoming resize events (#166) and improve performance in certain situations (pasting text via terminal facilities) restructure the event input processing:

  • Drain all crossterm events currently available
  • Prioritize the last resize and discard intermmediates
  • Join all EditCommands to be processessed together before handing them to the internal event handler which will trigger a repaint

sholderbach and others added 3 commits November 10, 2021 00:29
This attempts to address #166, some slowness is still observed

Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
@sholderbach
Copy link
Member Author

Note: previously lived unrelated under #164

@sophiajt
Copy link
Contributor

This looks good to me. And trying it out, it's definitely a big improvement over what we had

@sophiajt sophiajt merged commit 1b24499 into main Nov 10, 2021
@sophiajt sophiajt deleted the event-management branch November 10, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants