List that space can be bound through Char(' ')
#486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary to complete nushell/nushell#6590 (Comment: this whole module feels intricately linked to the nushell implementation as we do not implement the string parsing in reedline)
sholderbach
added
A-ViKeybinding
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
Sep 20, 2022
sholderbach
added a commit
to nushell/nushell
that referenced
this pull request
Sep 20, 2022
* Add "space" key to bind in vi normal mode Implements #6586 No special logic to prevent you from binding it in other modes! Needs a separate change to reedline to make it available in the default listing of `keybindings list`. * Update reedline to report the available `space` Pulls in nushell/reedline#486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to complete nushell/nushell#6590
(Comment: this whole module feels intricately linked to the nushell
implementation as we do not implement the string parsing in reedline)