-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cpex): set term to next term instead of current #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3631 +/- ##
=======================================
Coverage 53.24% 53.24%
=======================================
Files 271 271
Lines 5862 5862
Branches 1396 1396
=======================================
Hits 3121 3121
Misses 2741 2741 ☔ View full report in Codecov by Sentry. |
chrisgzf
approved these changes
Oct 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alissayarmantho
added a commit
that referenced
this pull request
Oct 8, 2023
* chore(deps): update dependency postcss to v8.4.31 [security] (#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (#3622) * chore(cpex): set term to next term instead of current (#3631) * Change MPE to CPE and Open MPE (#3623) * Fix serverless function not working (#3623) * Change modules to courses (#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
alissayarmantho
added a commit
that referenced
this pull request
Oct 8, 2023
* chore(deps): update dependency postcss to v8.4.31 [security] (#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (#3622) * chore(cpex): set term to next term instead of current (#3631) * Change MPE to CPE and Open MPE (#3623) * Fix serverless function not working (#3623) * Change modules to courses (#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (#3623) * Change package.json to use openssl legacy (#3623) Change package.json to set env variable(#3623) * Remove nodeoptions from package.json and change mpe api link (#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
alissayarmantho
pushed a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 8, 2023
alissayarmantho
added a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 14, 2023
…fications#3632) * chore(deps): update dependency postcss to v8.4.31 [security] (nusmodifications#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (nusmodifications#3622) * chore(cpex): set term to next term instead of current (nusmodifications#3631) * Change MPE to CPE and Open MPE (nusmodifications#3623) * Fix serverless function not working (nusmodifications#3623) * Change modules to courses (nusmodifications#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (nusmodifications#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
alissayarmantho
added a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 14, 2023
* chore(deps): update dependency postcss to v8.4.31 [security] (nusmodifications#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (nusmodifications#3622) * chore(cpex): set term to next term instead of current (nusmodifications#3631) * Change MPE to CPE and Open MPE (nusmodifications#3623) * Fix serverless function not working (nusmodifications#3623) * Change modules to courses (nusmodifications#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (nusmodifications#3623) * Change package.json to use openssl legacy (nusmodifications#3623) Change package.json to set env variable(nusmodifications#3623) * Remove nodeoptions from package.json and change mpe api link (nusmodifications#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
alissayarmantho
pushed a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 14, 2023
alissayarmantho
pushed a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 14, 2023
alissayarmantho
added a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 14, 2023
…fications#3632) * chore(deps): update dependency postcss to v8.4.31 [security] (nusmodifications#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (nusmodifications#3622) * chore(cpex): set term to next term instead of current (nusmodifications#3631) * Change MPE to CPE and Open MPE (nusmodifications#3623) * Fix serverless function not working (nusmodifications#3623) * Change modules to courses (nusmodifications#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (nusmodifications#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
alissayarmantho
added a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 14, 2023
* chore(deps): update dependency postcss to v8.4.31 [security] (nusmodifications#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (nusmodifications#3622) * chore(cpex): set term to next term instead of current (nusmodifications#3631) * Change MPE to CPE and Open MPE (nusmodifications#3623) * Fix serverless function not working (nusmodifications#3623) * Change modules to courses (nusmodifications#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (nusmodifications#3623) * Change package.json to use openssl legacy (nusmodifications#3623) Change package.json to set env variable(nusmodifications#3623) * Remove nodeoptions from package.json and change mpe api link (nusmodifications#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
alissayarmantho
pushed a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 14, 2023
alissayarmantho
added a commit
that referenced
this pull request
Oct 14, 2023
* chore(deps): update dependency postcss to v8.4.31 [security] (#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (#3622) * chore(cpex): set term to next term instead of current (#3631) * Change MPE to CPE and Open MPE (#3623) * Fix serverless function not working (#3623) * Change modules to courses (#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
alissayarmantho
added a commit
that referenced
this pull request
Oct 14, 2023
* chore(deps): update dependency postcss to v8.4.31 [security] (#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (#3622) * chore(cpex): set term to next term instead of current (#3631) * Change MPE to CPE and Open MPE (#3623) * Fix serverless function not working (#3623) * Change modules to courses (#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (#3623) * Change package.json to use openssl legacy (#3623) Change package.json to set env variable(#3623) * Remove nodeoptions from package.json and change mpe api link (#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
chrisgzf
added a commit
that referenced
this pull request
Oct 14, 2023
* Change MPE to CPE and Open MPE (#3623) (#3627) Prepare for CPEx open * Fix serverless function error 500 in vercel (#3623) (#3628) * Fix serverless function not working (#3623) * Change modules to courses (#3623) (#3629) * Change modules to courses (#3623) * Change inS1 and inS2 MPE to CPEx and fix private key parsing (#3632) * chore(deps): update dependency postcss to v8.4.31 [security] (#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (#3622) * chore(cpex): set term to next term instead of current (#3631) * Change MPE to CPE and Open MPE (#3623) * Fix serverless function not working (#3623) * Change modules to courses (#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com> * Update nus-auth.ts (#3623) Remove previous changes * Try to fix openssl legacy error (#3623) * chore(deps): update dependency postcss to v8.4.31 [security] (#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (#3622) * chore(cpex): set term to next term instead of current (#3631) * Change MPE to CPE and Open MPE (#3623) * Fix serverless function not working (#3623) * Change modules to courses (#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (#3623) * Change package.json to use openssl legacy (#3623) Change package.json to set env variable(#3623) * Remove nodeoptions from package.json and change mpe api link (#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com> * Update ModuleForm.tsx to use CPEx (#3623) * Update FAQ to point to CPEx FAQ (#3623) * Regenerate yarn lockfile using yarn classic v1 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
alissayarmantho
added a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 21, 2023
* chore(deps): update dependency postcss to v8.4.31 [security] (nusmodifications#3630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(cpex): add standalone scraper (nusmodifications#3622) * chore(cpex): set term to next term instead of current (nusmodifications#3631) * Change MPE to CPE and Open MPE (nusmodifications#3623) * Fix serverless function not working (nusmodifications#3623) * Change modules to courses (nusmodifications#3623) * Change inS1 and inS2 from mpe to cpex and fix private key parsing (nusmodifications#3623) * Change package.json to use openssl legacy (nusmodifications#3623) Change package.json to set env variable(nusmodifications#3623) * Remove nodeoptions from package.json and change mpe api link (nusmodifications#3623) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Goh <chrisgzf@gmail.com> Co-authored-by: Ravern Koh <ravernkoh@gmail.com>
alissayarmantho
pushed a commit
to alissayarmantho/nusmods
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3622.