Remove sha1 chain - should default to system roots #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two valid chains to follow for the Nutshell certificate. One is signed by “RapidSSL SHA256 CA - G3” root, and one is signed by “Equifax Secure Certificate Authority”. The Equifax chain has a SHA1 signature algorithm in the chain. This is now bad practice and has been deprecated, however, we shipped this api with the “Equifax Secure Certificate Authority” as the CA which is breaking installs. This commit removes this second chain and relies on the (OS) built in root certificates which should contain the “RapidSSL SHA256 CA - G3” root. - https://community.qualys.com/blogs/securitylabs/2014/09/09/sha1-deprecation-what-you-need-to-know - http://sha1affected.com/
flav
added a commit
that referenced
this pull request
Mar 4, 2015
Remove sha1 chain - should default to system roots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two valid chains to follow for the Nutshell certificate. One is signed by “GeoTrust Global CA” root, and the other is signed by “Equifax Secure Certificate Authority” root. The Equifax chain has a SHA1 signature algorithm within the chain which is now bad practice and has been deprecated. We originally shipped this api code with the “Equifax Secure Certificate Authority” as a hard coded CA which is now broken. This commit removes the hard coded Equifaxt root and relies on the (OS) built in root certificates which should contain the “GeoTrust Global CA” root.