New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

重写H2下获得表索引方法 #1249

Merged
merged 2 commits into from Apr 18, 2017

Conversation

Projects
None yet
3 participants
@jiyuefeng
Contributor

jiyuefeng commented Apr 18, 2017

修复问题 #1248

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 18, 2017

Codecov Report

Merging #1249 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
- Coverage   47.55%   47.55%   -0.01%     
==========================================
  Files         793      793              
  Lines       33266    33276      +10     
  Branches     7175     7176       +1     
==========================================
+ Hits        15821    15825       +4     
- Misses      15337    15345       +8     
+ Partials     2108     2106       -2
Impacted Files Coverage Δ
src/org/nutz/dao/impl/jdbc/h2/H2JdbcExpert.java 17.64% <0%> (-25.22%) ⬇️
src/org/nutz/lang/random/ArrayRandom.java 94.44% <0%> (+11.11%) ⬆️
src/org/nutz/lang/random/ListRandom.java 94.44% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a2661...22060cb. Read the comment docs.

codecov-io commented Apr 18, 2017

Codecov Report

Merging #1249 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
- Coverage   47.55%   47.55%   -0.01%     
==========================================
  Files         793      793              
  Lines       33266    33276      +10     
  Branches     7175     7176       +1     
==========================================
+ Hits        15821    15825       +4     
- Misses      15337    15345       +8     
+ Partials     2108     2106       -2
Impacted Files Coverage Δ
src/org/nutz/dao/impl/jdbc/h2/H2JdbcExpert.java 17.64% <0%> (-25.22%) ⬇️
src/org/nutz/lang/random/ArrayRandom.java 94.44% <0%> (+11.11%) ⬆️
src/org/nutz/lang/random/ListRandom.java 94.44% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a2661...22060cb. Read the comment docs.

@wendal

This comment has been minimized.

Show comment
Hide comment
@wendal

wendal Apr 18, 2017

Member

toUpperCase()是必须的吗? javadoc没写全哦, 要么不写,要么写全.

Member

wendal commented Apr 18, 2017

toUpperCase()是必须的吗? javadoc没写全哦, 要么不写,要么写全.

@jiyuefeng

This comment has been minimized.

Show comment
Hide comment
@jiyuefeng

jiyuefeng Apr 18, 2017

Contributor

@wendal toUpperCase() 是必须的。因H2 表名大写。javadoc 是删除掉么? 是需要重新发起一个 pull request?

Contributor

jiyuefeng commented Apr 18, 2017

@wendal toUpperCase() 是必须的。因H2 表名大写。javadoc 是删除掉么? 是需要重新发起一个 pull request?

@wendal

This comment has been minimized.

Show comment
Hide comment
@wendal

wendal Apr 18, 2017

Member

在自己的库提交完,点创建pull req, 会自动更新这个pull req的

Member

wendal commented Apr 18, 2017

在自己的库提交完,点创建pull req, 会自动更新这个pull req的

@wendal wendal merged commit 330386b into nutzam:master Apr 18, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment