WEBUI-186: add validation to save search name and also fix cancel button #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View issue in JIRA: WEBUI-186: Fix saving search containing slash ('/') character |
andreacornaglia
force-pushed
the
WEBUI-186-fixSaveSearchInputValidation
branch
from
94c60b5
to
4f6b88e
Compare
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-web-ui-pr-1180 here |
mnixo
approved these changes
Mar 16, 2021
richardsd
approved these changes
Mar 16, 2021
semisse
reviewed
Mar 17, 2021
| @@ -1261,6 +1261,7 @@ | |||
| "searchForm.renamePopup.heading": "Rename Saved Search", | |||
| "searchForm.renamePopup.label": "Enter a new name for your saved search.", | |||
| "searchForm.savePopup.heading": "Save Search", | |||
| "searchForm.savePopup.error": "You cannot use the character '/' in the name", | |||
There was a problem hiding this comment.
Please, move this line above to keep alphabetical order
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-web-ui-pr-1180 here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.