Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXP-29815: add an endpoint to recompute video renditions #4500

Merged
merged 4 commits into from Jul 15, 2021
Merged

NXP-29815: add an endpoint to recompute video renditions #4500

merged 4 commits into from Jul 15, 2021

Conversation

charlesboidot
Copy link
Contributor

No description provided.

@nuxeojenkins
Copy link
Collaborator

View issue in JIRA: NXP-29815: Add endpoint for video rendition recomputation

@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch 2 times, most recently from 930e850 to 74967fa Compare December 3, 2020 13:06
@charlesboidot charlesboidot marked this pull request as ready for review December 3, 2020 13:08
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch 2 times, most recently from 274fb1d to 0235b96 Compare December 7, 2020 09:23
@kevinleturc kevinleturc self-requested a review December 7, 2020 13:06
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch from 0235b96 to 3d4fc36 Compare December 8, 2020 09:40
@ataillefer ataillefer force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch from 3d4fc36 to a7522df Compare December 9, 2020 14:02
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch from a7522df to 546c26b Compare December 9, 2020 15:44
kevinleturc
kevinleturc requested changes Dec 9, 2020
View reviewed changes
modules/platform/nuxeo-platform-importer/nuxeo-importer-core/pom.xml Outdated Show resolved Hide resolved
...e/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeRenditionActionValidation.java Outdated Show resolved Hide resolved
...e/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeRenditionActionValidation.java Outdated Show resolved Hide resolved
...video-core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeRenditionsAction.java Outdated Show resolved Hide resolved
...video-core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeRenditionsAction.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch 5 times, most recently from dc13e88 to fe4e027 Compare December 18, 2020 08:49
kevinleturc
kevinleturc requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@kevinleturc kevinleturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several of my comments are to apply to several locations, this is the case for Sys out, var...

...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch 3 times, most recently from 0347c3a to 041193b Compare January 4, 2021 11:37
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch from 041193b to 639f045 Compare January 12, 2021 13:52
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch 2 times, most recently from 448a459 to 7d26739 Compare January 12, 2021 16:33
kevinleturc
kevinleturc reviewed Jan 13, 2021
View reviewed changes
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...core/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...ain/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsActionValidation.java Outdated Show resolved Hide resolved
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch 2 times, most recently from 363846a to e067be8 Compare January 13, 2021 10:55
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch from f3c43b4 to 55f715f Compare February 2, 2021 15:37
ataillefer
ataillefer previously approved these changes Feb 3, 2021
View reviewed changes
@kevinleturc
Copy link
Member

We're gonna add some feature to this PR since we found something we can improve. Please wait before reviewing it.

@kevinleturc kevinleturc marked this pull request as draft February 3, 2021 16:09
efge
efge requested changes Feb 3, 2021
View reviewed changes
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...video-rest/src/test/java/org/nuxeo/ecm/restapi/server/jaxrs/management/TestVideosObject.java Outdated Show resolved Hide resolved
...ideo/src/main/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsAction.java Outdated Show resolved Hide resolved
...ain/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsActionValidation.java Outdated Show resolved Hide resolved
...ain/java/org/nuxeo/ecm/platform/video/service/RecomputeVideoConversionsActionValidation.java Outdated Show resolved Hide resolved
modules/platform/video/nuxeo-platform-video-rest/src/test/resources/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
modules/platform/video/nuxeo-platform-video/src/test/resources/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
@charlesboidot charlesboidot force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch 5 times, most recently from 93be796 to 7f65296 Compare February 9, 2021 12:57
@charlesboidot charlesboidot marked this pull request as ready for review February 12, 2021 11:09
@kevinleturc kevinleturc force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch 2 times, most recently from 69f2e7e to b56b270 Compare June 14, 2021 13:00
@kevinleturc
Copy link
Member

I rebased the branch + take into account latest comments.

@kevinleturc kevinleturc force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch from b56b270 to 08e8d86 Compare July 6, 2021 14:38
@kevinleturc kevinleturc force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch from 08e8d86 to d5864e6 Compare July 7, 2021 10:19
@kevinleturc kevinleturc force-pushed the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch from d5864e6 to cbbb2e0 Compare July 7, 2021 14:12
@kevinleturc kevinleturc merged commit cfeedd5 into master Jul 15, 2021
@kevinleturc kevinleturc deleted the feature-NXP-29825-add-video-rendition-recomputation-endpoint branch July 15, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troger troger troger approved these changes

@efge efge efge approved these changes

@ataillefer ataillefer ataillefer approved these changes

@kevinleturc kevinleturc Awaiting requested review from kevinleturc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@charlesboidot @nuxeojenkins @efge @troger @kevinleturc @ataillefer