Use encodeURI/decodeURI functions that match the MDN spec #11

Merged
merged 1 commit into from Apr 27, 2012

Conversation

Projects
None yet
3 participants

The encodeURI/decodeURI functions didn't escape all characters (e.g. tabs weren't escaped)
I replaced them with a function found here: http://stackoverflow.com/questions/4929584/encodeuri-in-php#answer-6059053

This should fix issue #7 as well

nuxodin added a commit that referenced this pull request Apr 27, 2012

Merge pull request #11 from lukasberns/master
Use encodeURI/decodeURI functions that match the MDN spec

@nuxodin nuxodin merged commit 1f97999 into nuxodin:master Apr 27, 2012

Contributor

ktomk commented May 6, 2012

Thanks for the patch, I improved the code as the variant on stackoverflow had licensing implications (their content is cc-licensed which does not suite well for software according to Creative Commons) and equally important was not a correct port to PHP from ecmascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment