fix(style): resolve uncorrect remove style regex - #225
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 69.02% 67.02% -2.01%
==========================================
Files 5 5
Lines 184 188 +4
Branches 52 52
==========================================
- Hits 127 126 -1
- Misses 41 46 +5
Partials 16 16
Continue to review full report at Codecov.
|
Member
Author
|
@farnabaz |
Member
|
@potato4d We can create a separate test for it by disabling beforeAll(async () => {
const port = await getPort({ port: getPort.makeRange(3000, 3100) })
url = path => `http://localhost:${port}${path}`
const config = {
...defaultConfig,
buildDir: '.nuxt/test.styles',
dev: false,
build: {
extractCSS: false
},
}
nuxt = new Nuxt(config)
await nuxt.ready()
await new Builder(nuxt).build()
return await nuxt.listen(port)
})I'll merge this PR and release v0.5.3. You are more than welcome to create another PR for tests ❤️ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request resolves
</style><style>pattern regex problem.Example
as-is
to-be