Allowing extending axios

[mathieutu]

Hi.
I've spent several hours to understand why my axios default config (added in ~/plugins/axios.js as explained here) were not applied when fetchUser was called, at the app init.

In fact, you add the auth plugin just after the first axios plugin, so it inits before the config file:

auth-module/lib/module.js

Lines 93 to 96 in ca8785f

	const index = this.options.plugins.findIndex(p =>
	/axios\.js$/.test(p.src || p)
	)
	this.options.plugins.splice(index + 1, 0, join(this.options.buildDir, dst))

With that, I can't use this module at all, because all the axios config I need (especially x-api-key header) is set after the auth plugin.
😞

Do you have any quick solution, or do you want a PR?

_{This question is available on Nuxt.js community (#c71)}

[breakingrobot]

@mathieutu We would appreciate a PR on this one, still if you don't have the time, we will try to fix it asap ;)

[mathieutu]

ok, I'll do it when I get some time.

[mathieutu]

@breakingrobot do you see any problem if instead of adding the plugin just after $axios we just push it at the end of plugins array and let the user choose the order? Why did you do this particular trick?

-  // ...add plugin just after $axios
-  const index = this.options.plugins.findIndex(p =>
-    /axios\.js$/.test(p.src || p)
-  )
-  this.options.plugins.splice(index + 1, 0, join(this.options.buildDir, dst))

+  // just push the plugin at the end
+  this.options.plugins.push(join(this.options.buildDir, dst))

Thanks for your answer.

[pi0]

@mathieutu But we can't add it to the end. Users may provide plugins to extend auth too (just like axios) (thus depend on it). BTW Why don't use top-level axios configuration? If it is just to prevent users confusing we may remove auto axios import.

Update: now auth uses plugins.push and instead has a plugins option to allow extending.

[mathieutu]

Sounds perfect for me!
👌