Full support "Authorization Code Grant" & Refresh Token#145
Merged
pi0 merged 4 commits intonuxt-community:devfrom Apr 16, 2018
robsontenorio:dev
Merged
Full support "Authorization Code Grant" & Refresh Token#145pi0 merged 4 commits intonuxt-community:devfrom robsontenorio:dev
pi0 merged 4 commits intonuxt-community:devfrom
robsontenorio:dev
Conversation
robsontenorio
changed the title
pi0
approved these changes
Apr 15, 2018
Contributor
Author
|
@pi0 thanks for approval! Effectively when it will be merged? |
Member
|
As this is a non breaking one will be shipped in next semver/minor release :) Thanks for yoyr help 🤗 |
breakingrobot
approved these changes
Apr 16, 2018
Contributor
breakingrobot
left a comment
breakingrobot
left a comment
There was a problem hiding this comment.
Just a small variable naming issue to me.
lib/schemes/oauth2.js
Outdated
| let token = parsedQuery[this.options.token_key || 'access_token'] | ||
|
|
||
| // refresh token | ||
| let refresh_token = parsedQuery[this.options.refresh_token_key || 'refresh_token'] |
Contributor
There was a problem hiding this comment.
Can you use camel casing instead of underscore casing?
Contributor
Author
|
@breakingrobot @pi0 done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.