Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setUserToken #278

Merged
merged 2 commits into from Feb 7, 2019
Merged

setUserToken #278

merged 2 commits into from Feb 7, 2019

Conversation

dgwight
Copy link
Contributor

@dgwight dgwight commented Dec 17, 2018

After registration and reseting a password, my api returns an auth token and which I would like to use to set the current user.

To do this currently, I was using code that looks like this:

const token = `Bearer ${data.access_token}`

this.$auth.setToken(this.$store.state.auth.strategy, token)
this.$auth.strategy._setToken(token)
return this.$auth.fetchUser()

I believe this is a common use case, so this pr adds a function $auth.setUserToken(token) to correctly set the user with an auth code. The function setToken does not set the Authorization header, so it doesn't handle this use case very well.

Thanks!

@farnabaz farnabaz requested a review from pi0 Jan 1, 2019
@GMounir
Copy link

GMounir commented Jan 3, 2019

Thank you i was look for solution like this...

@farnabaz
Copy link
Member

farnabaz commented Jan 11, 2019

@dgwight Thank you for your great pull request
I think we must implement the same functionality in the oauth2 scheme

@farnabaz farnabaz merged commit 9f53a4f into nuxt-community:dev Feb 7, 2019
@ruudboon
Copy link

ruudboon commented May 14, 2019

Great. Hopefully this will be released soon

@pi0 pi0 mentioned this pull request May 23, 2019
@pi0
Copy link
Member

pi0 commented May 30, 2019

This PR has been published in v4.6.0

@itsrachelfish
Copy link

itsrachelfish commented Nov 21, 2019

@dgwight Why does calling setUserToken always force a redirect to the home page, even when watchLoggedIn and redirect are both set to false in my nuxt config?

I had to use setToken instead of setUserToken to get around this problem.

@T0TProduction
Copy link
Contributor

T0TProduction commented Feb 12, 2020

I didn't open an extra issue because I feel this is still part of the PR.
I think I found what is also the source of above-mentioned issue. Not sure if the "solution" keeps other things from breaking though.
In line 59 of "local.js" we use await this._logoutLocally() in the beginning of "setUserToken()"
This logs the user out, resulting in above-mentioned issues as well as (if we keep watchLoggedIn ON ) to some unexpected logout but instantly logged in wonkiness when using refresh tokens (custom ones, because this module hasn't released them, but they use the default local scheme)

The solution for me was to simply comment out the line mentioned above. Since the setUserToken overwrites the token anyways it made no difference.
Is that line really needed then? Don't know the entire codebase enough to determine if it is.
At first glance, it seems just "lazily" copy-pasted from "login()" for the initial PR.

@dgwight
Copy link
Contributor Author

dgwight commented Feb 12, 2020

@itsrachelfish the redirect unintended, the code for setUserToken absolutely was "lazily" copy-pasted from "login()" for the initial PR.

@T0TProduction could you push up a fix with that line removed?

@T0TProduction
Copy link
Contributor

T0TProduction commented Feb 14, 2020

@dgwight ^ opened a PR but I guess it will take some time until someone reviews it.

pi0 added a commit that referenced this pull request Mar 2, 2020
@pi0
Copy link
Member

pi0 commented Mar 15, 2020

Released with v4.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants