Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utilities): avoid send xxx=undefined in query #387

Merged
merged 4 commits into from Jun 24, 2019

Conversation

bluelovers
Copy link
Contributor

this help when use other service by oauth2

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #387 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #387   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6811ab5...c705e60. Read the comment docs.

lib/core/utilities.js Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query parts without value are also valid (Like ?is_vip). So we probably need to only omit =undefined part if it seems ugly.

@pi0 pi0 added the pending label Jun 23, 2019
pi0
pi0 approved these changes Jun 24, 2019
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 removed the pending label Jun 24, 2019
@pi0 pi0 merged commit 7c79fd4 into nuxt-community:dev Jun 24, 2019
@pi0
Copy link
Member

pi0 commented Jun 24, 2019

Landed in 4.8.1

tanutsun pushed a commit to tanutsun/auth-module that referenced this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants