Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain need to transpile nanoid for ie11 support #472

Merged
merged 1 commit into from Dec 26, 2019

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 24, 2019

The current version of nanoid uses Math.clz32 which is not supported by IE11. This documentation change explains the need to transpile nanoid for projects that need to support IE11.

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #472 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #472   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21de05...a1ffe47. Read the comment docs.

pi0
pi0 approved these changes Dec 26, 2019
Copy link
Member

@pi0 pi0 left a comment

Thanks!

@pi0 pi0 merged commit 5c7e52d into nuxt-community:dev Dec 26, 2019
pi0 added a commit that referenced this pull request Dec 27, 2019
@pi0
Copy link
Member

pi0 commented Dec 27, 2019

Update: Removed from docs. Now we always transpile nanoid to be less tricky :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants