Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the trailing slash of paths in isSameURL #542

Merged
merged 2 commits into from Mar 2, 2020
Merged

fix: remove the trailing slash of paths in isSameURL #542

merged 2 commits into from Mar 2, 2020

Conversation

ElmerZhang
Copy link
Contributor

@ElmerZhang ElmerZhang commented Feb 27, 2020

Comparing URLs in isSameURL should remove the trailing slash.
Comparison of https://example.com/signIn with https://example.com/signIn/ should return true.

ElmerZhang added 2 commits Feb 27, 2020
Comparing URLs in isSameURL should remove the trailing slash.
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #542 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #542   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a1275...b244ee8. Read the comment docs.

@pi0 pi0 changed the title Remove the trailing slash of paths in isSameURL fix: remove the trailing slash of paths in isSameURL Mar 2, 2020
pi0
pi0 approved these changes Mar 2, 2020
@pi0 pi0 merged commit fb63f6f into nuxt-community:dev Mar 2, 2020
3 checks passed
@pi0
Copy link
Member

pi0 commented Mar 2, 2020

Thanks!

@pi0
Copy link
Member

pi0 commented Mar 15, 2020

Released with v4.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants