Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear tokens when calling $auth.reset() #544

Merged
merged 3 commits into from Mar 3, 2020
Merged

fix: clear tokens when calling $auth.reset() #544

merged 3 commits into from Mar 3, 2020

Conversation

JoaoPedroAS51
Copy link
Collaborator

@JoaoPedroAS51 JoaoPedroAS51 commented Mar 3, 2020

The purpose of this PR is refactor the methods logoutLocally of local scheme and logout of oauth2 scheme.
By now they are clearing the tokens and calling $auth.reset(), but with these changes they will be the reset method. That way, whenever $auth.reset() is called (e.g. when resetOnError is true) it will reset properly.

This closes #172

@JoaoPedroAS51 JoaoPedroAS51 requested a review from pi0 Mar 3, 2020
JoaoPedroAS51 added a commit that referenced this pull request Mar 3, 2020
@pi0 pi0 changed the title fix: reset fix: clear tokens when calling $auth.reset() Mar 3, 2020
pi0
pi0 approved these changes Mar 3, 2020
Copy link
Member

@pi0 pi0 left a comment

Beautiful! thanks ❤️

@pi0 pi0 merged commit ab75ebc into dev Mar 3, 2020
3 checks passed
@pi0 pi0 deleted the fix/reset branch Mar 3, 2020
@pi0
Copy link
Member

pi0 commented Mar 15, 2020

Released with v4.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After token expiration the authorization header on axios still presents
2 participants